Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCI-3837] - Remove tautological check inside EVM TXM #13857

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Farber98
Copy link
Contributor

@Farber98 Farber98 commented Jul 15, 2024

Description

There’s a tautological condition in the TXM code that can be removed. if err != nil is already true due to previous check in outer if

Acceptance Criteria

  • Tautological condition has been removed.

Ticket:

Resources:

@Farber98 Farber98 requested a review from a team as a code owner July 15, 2024 18:52
@Farber98 Farber98 self-assigned this Jul 15, 2024
@Farber98 Farber98 requested a review from a team as a code owner July 15, 2024 18:56
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dimriou dimriou added this pull request to the merge queue Jul 16, 2024
Merged via the queue into develop with commit 6bf25fc Jul 16, 2024
115 checks passed
@dimriou dimriou deleted the BCI-3837-remove-tautological-condition-evm-txm branch July 16, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants