Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KS-307: Upgrade keystone contracts to 0.8.24 #13546

Merged
merged 16 commits into from
Jun 21, 2024

Conversation

cds95
Copy link
Contributor

@cds95 cds95 commented Jun 13, 2024

@cds95
Copy link
Contributor Author

cds95 commented Jun 13, 2024

Is pnpm-lock.yaml expected to be updated when I upgrade the Solidity version here.

forwarder: ../../../contracts/solc/v0.8.19/KeystoneForwarder/KeystoneForwarder.abi ../../../contracts/solc/v0.8.19/KeystoneForwarder/KeystoneForwarder.bin bd15b7c5cecc87d44cac0b8414627cfb2c0e1cdd554df60a50dcb682f9a05129
keystone_capability_registry: ../../../contracts/solc/v0.8.19/CapabilityRegistry/CapabilityRegistry.abi ../../../contracts/solc/v0.8.19/CapabilityRegistry/CapabilityRegistry.bin cc978f3a11c405f0559cf1d371ed8a1553d9b9975e8b3915a142cc781d280823
ocr3_capability: ../../../contracts/solc/v0.8.19/OCR3Capability/OCR3Capability.abi ../../../contracts/solc/v0.8.19/OCR3Capability/OCR3Capability.bin 144f23145878b95d1672e4919874eddeeaa38ce520d0edbe72c6677e39bb4741
forwarder: ../../../contracts/solc/v0.8.24/KeystoneForwarder/KeystoneForwarder.abi ../../../contracts/solc/v0.8.24/KeystoneForwarder/KeystoneForwarder.bin dc98a86a3775ead987b79d5b6079ee0e26f31c0626032bdd6508f986e2423227
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected when I upgrade? These were autogenerated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI runs make generate too, and it did not flag a diff, so this seems correct.

@cds95 cds95 force-pushed the KS-307/upgrade-cr-registry-contract-to-0.8.24 branch from c4651e6 to e79d27b Compare June 15, 2024 01:18
DeividasK
DeividasK previously approved these changes Jun 18, 2024
@cl-sonarqube-production
Copy link

@archseer archseer added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@archseer archseer added this pull request to the merge queue Jun 21, 2024
Merged via the queue into develop with commit 10ddafa Jun 21, 2024
112 checks passed
@archseer archseer deleted the KS-307/upgrade-cr-registry-contract-to-0.8.24 branch June 21, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants