Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCF-3247] - Add confidence levels to CR GetLatestValue #13514

Merged
merged 13 commits into from
Jul 11, 2024
Merged

[BCF-3247] - Add confidence levels to CR GetLatestValue #13514

merged 13 commits into from
Jul 11, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Jun 11, 2024 •
edited
Loading

Description

  • Implemented confidence level(finality) parameter for GetLatestValue events and method.

Related PRs

chainlink-common
chainlink-feeds
chainlink-solana

Merge order

  1. common
  2. feeds but first change common ref
  3. solana but first change common ref
  4. core but first change feeds, solana and common refs

@ilija42 ilija42 mentioned this pull request Jun 12, 2024
Merged
@ilija42 ilija42 mentioned this pull request Jul 1, 2024
Merged
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 41ffc8c to b3a703d Compare July 1, 2024 15:00
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from b3a703d to a3153ec Compare July 1, 2024 15:39
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from a3153ec to df9844b Compare July 1, 2024 16:22
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch 2 times, most recently from a258c06 to 7665bad Compare July 2, 2024 19:27
@ilija42 ilija42 mentioned this pull request Jul 2, 2024
Merged
@ilija42 ilija42 changed the title BCF-3247 - Initial Add confidence levels to CR GetLatestValue [BCF-3247] - Initial Add confidence levels to CR GetLatestValue Jul 2, 2024
@ilija42 ilija42 changed the title [BCF-3247] - Initial Add confidence levels to CR GetLatestValue [BCF-3247] - Add confidence levels to CR GetLatestValue Jul 2, 2024
@ilija42 ilija42 marked this pull request as ready for review July 2, 2024 20:06
@ilija42 ilija42 requested review from a team and RensR as code owners July 2, 2024 20:06
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 7665bad to 036daf1 Compare July 3, 2024 11:41
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 036daf1 to aa7521a Compare July 3, 2024 11:48
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from a596739 to 2b25a3d Compare July 3, 2024 12:22
@ilija42
Merge remote-tracking branch 'origin/develop' into BCF-3247-CR-contra…
8d5d76d 
…ct-read-finality

# Conflicts:
#	integration-tests/go.mod
#	integration-tests/load/go.mod
@ilija42 ilija42 dismissed stale reviews from krehermann and jmank88 via 8d5d76d July 11, 2024 15:39
@ilija42 ilija42 requested review from jmank88 and krehermann July 11, 2024 15:42
krehermann
krehermann previously approved these changes Jul 11, 2024
View reviewed changes
@ilija42 ilija42 requested a review from a team as a code owner July 11, 2024 18:30
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 737623b to 20060fb Compare July 11, 2024 18:35
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 20060fb to 8e3d225 Compare July 11, 2024 18:36
@aalu1418 aalu1418 mentioned this pull request Jul 11, 2024
Merged
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
24.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ilija42 ilija42 requested a review from krehermann July 11, 2024 18:59
@krehermann krehermann enabled auto-merge July 11, 2024 19:01
@krehermann krehermann added this pull request to the merge queue Jul 11, 2024
Merged via the queue into develop with commit f84a3f2 Jul 11, 2024
113 of 114 checks passed
@krehermann krehermann deleted the BCF-3247-CR-contract-read-finality branch July 11, 2024 19:47
This was referenced Jul 11, 2024
Draft
Closed
@chainchad chainchad mentioned this pull request Jul 29, 2024
Merged
This was referenced Jul 31, 2024
Draft
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EasterTheBunny EasterTheBunny EasterTheBunny left review comments

@krehermann krehermann krehermann approved these changes

@jmank88 jmank88 jmank88 approved these changes

@RensR RensR Awaiting requested review from RensR

@reductionista reductionista Awaiting requested review from reductionista

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilija42 @jmank88 @EasterTheBunny @krehermann