Ks 316 replace secret usage in transmission protocol with the workflow execution #13501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
previously approved these changes
Jun 11, 2024
ettec
force-pushed
the
KS-316-Replace-secret-usage-in-transmission-protocol-with-the-workflow-execution-id
branch
from
b12cb7d to
4fdcaee
Compare
ettec
force-pushed
the
KS-316-Replace-secret-usage-in-transmission-protocol-with-the-workflow-execution-id
branch
from
4fdcaee to
a1e48cc
Compare
cedric-cordenier
previously approved these changes
Jun 11, 2024
krehermann
previously approved these changes
Jun 11, 2024
ettec
force-pushed
the
KS-316-Replace-secret-usage-in-transmission-protocol-with-the-workflow-execution-id
branch
from
0f62246 to
1644c6a
Compare
ettec
force-pushed
the
KS-316-Replace-secret-usage-in-transmission-protocol-with-the-workflow-execution-id
branch
from
1644c6a to
ac77029
Compare
cedric-cordenier
approved these changes
Jun 11, 2024
krehermann
approved these changes
Jun 11, 2024
ettec
deleted the
KS-316-Replace-secret-usage-in-transmission-protocol-with-the-workflow-execution-id
branch
DeividasK
reviewed
Jun 12, 2024
| return nil, errors.New("workflow ID and workflow execution ID must be set in request metadata") | ||
| } | ||
|
|
||
| transmissionID := req.Metadata.WorkflowID + req.Metadata.WorkflowExecutionID |
There was a problem hiding this comment.
WorkflowExecutionID = WorkflowID + EventID, so adding WorkflowID again seems redundant?
There was a problem hiding this comment.
agree, thats not necessary, no material impact I think? I'll get on to it shortly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.