Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase num optimizations for coordinator v2.5 to 500 #12531

Merged
merged 3 commits into from
Mar 21, 2024
Merged

increase num optimizations for coordinator v2.5 to 500 #12531

merged 3 commits into from
Mar 21, 2024

Conversation

jinhoonbang
Copy link
Contributor

Gas savings:

requestRandomWords
         | avg    | median | max   
before: | 28556  | 33256  | 38056 
after: | 28449  | 33138  | 37938

fulfillRandomWords
before:  | 127756 | 97780  | 231679
after: | 127449 | 97350  | 231444

@jinhoonbang jinhoonbang requested review from a team and RensR as code owners March 21, 2024 19:44
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

ibrajer
ibrajer previously approved these changes Mar 21, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jinhoonbang jinhoonbang added this pull request to the merge queue Mar 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 21, 2024
@jinhoonbang jinhoonbang added this pull request to the merge queue Mar 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2024
@jinhoonbang jinhoonbang added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit 88e010d Mar 21, 2024
116 checks passed
@jinhoonbang jinhoonbang deleted the increase-num-optimizations branch March 21, 2024 23:49
leeyikjiun
leeyikjiun reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@leeyikjiun leeyikjiun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should binary search for the max optimizer runs. 😄

kidambisrinivas pushed a commit that referenced this pull request Mar 27, 2024
@jinhoonbang @kidambisrinivas
increase num optimizations for coordinator v2.5 to 500 (#12531)
46bc9c7 
* increase num optimizations for coordinator v2.5 to 500

* add changeset

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeyikjiun leeyikjiun leeyikjiun left review comments

@ibrajer ibrajer ibrajer approved these changes

@RensR RensR Awaiting requested review from RensR

@kidambisrinivas kidambisrinivas Awaiting requested review from kidambisrinivas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinhoonbang @ibrajer @leeyikjiun