Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Argo CD app sync after image is published from PR #11750

Merged
merged 14 commits into from
Jan 12, 2024
Merged

Run Argo CD app sync after image is published from PR #11750

merged 14 commits into from
Jan 12, 2024

Conversation

chainchad
Copy link
Collaborator

No description provided.

@chainchad chainchad requested a review from a team January 11, 2024 19:19
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@chainchad chainchad added the crib Create ephemeral environment. label Jan 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

CRIB Environment Details ℹ️

CRIB activated via the 'crib' label. To destroy the environment, remove the 'crib' PR label or close the PR.

Please review the following details:

Subdomains

Use these subdomains to access the CRIB environment. They are prefixes to the internal base domain.

  • crib-chain-11750-node1.
  • crib-chain-11750-node2.
  • crib-chain-11750-node3.
  • crib-chain-11750-node4.
  • crib-chain-11750-node5.
  • crib-chain-11750-node6.
  • crib-chain-11750-geth-http.
  • crib-chain-11750-geth-ws.
  • crib-chain-11750-mockserver.

@chainchad chainchad marked this pull request as ready for review January 11, 2024 19:56
@chainchad chainchad added the github_actions Pull requests that update Github_actions code label Jan 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

CRIB Environment Details ℹ️

CRIB activated via the 'crib' label. To destroy the environment, remove the 'crib' PR label or close the PR.

Please review the following details:

Subdomains

Use these subdomains to access the CRIB environment. They are prefixes to the internal base domain.

  • crib-chain-11750-node1.
  • crib-chain-11750-node2.
  • crib-chain-11750-node3.
  • crib-chain-11750-node4.
  • crib-chain-11750-node5.
  • crib-chain-11750-node6.
  • crib-chain-11750-geth-http.
  • crib-chain-11750-geth-ws.
  • crib-chain-11750-mockserver.

@chainchad chainchad requested a review from momentmaker January 11, 2024 21:30
momentmaker
momentmaker approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@momentmaker momentmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:nice:

@chainchad chainchad enabled auto-merge January 12, 2024 13:24
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chainchad chainchad added this pull request to the merge queue Jan 12, 2024
Merged via the queue into develop with commit a69a78d Jan 12, 2024
80 checks passed
@chainchad chainchad deleted the re-2129/gap-argocd-sync branch January 12, 2024 14:05
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikburt erikburt erikburt approved these changes

@momentmaker momentmaker momentmaker approved these changes

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@jmank88 jmank88 Awaiting requested review from jmank88

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
crib Create ephemeral environment. github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chainchad @momentmaker @erikburt