Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCF-2880 remove unused db funcs and triggers #11730

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

krehermann
Copy link
Contributor

@krehermann krehermann commented Jan 10, 2024

auditing the db uncovered unused funcs and triggers that are removed in this pr.

i audited the go code by searching for the function names, trigger names, and the hard coded string in the PERFORM directive. there are no instances of any of them. presumably there listening functionality on the golang side was deleted and these db directives were forgotten about

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that whatever originally relied on these has been removed?

@krehermann krehermann added this pull request to the merge queue Jan 10, 2024
Merged via the queue into develop with commit c1eeb28 Jan 10, 2024
79 checks passed
@krehermann krehermann deleted the chore/rm-unused-db-funcs-triggers branch January 10, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants