bump common; use SugaredLogger methods #11556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
force-pushed
the
common-sugared-logger
branch
from
c67507e to
5062f07
Compare
jmank88
force-pushed
the
common-sugared-logger
branch
from
5062f07 to
189b07e
Compare
jmank88
requested review from
a team,
samsondav,
reductionista,
connorwstein and
prashantkumar1982
as code owners
|
SonarQube Quality Gate
|
samsondav
approved these changes
Dec 13, 2023
| @@ -40,7 +40,7 @@ type HeadTracker[ | |||
| BLOCK_HASH types.Hashable, | |||
| ] struct { | |||
| services.StateMachine | |||
| log logger.Logger | |||
| log logger.SugaredLogger | |||
There was a problem hiding this comment.
nit: what are your thoughts on changing log -> lggr?
There was a problem hiding this comment.
I'm in favor, but we can circle back to limit scope creep on this PR.
poopoothegorilla
approved these changes
Dec 13, 2023
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
chainlink-commonand swaps inSugaredLoggerwith chained method calls in places where we were wrapping calls to helper funcs.Requires: