golangci-lint: add noctx, sqlclosecheck; rm redundant revive.toml #11362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
vyzaldysanchez
previously approved these changes
Nov 22, 2023
jmank88
force-pushed
the
golangci-lint
branch
3 times, most recently
from
794fdb1 to
a547b2f
Compare
jmank88
force-pushed
the
golangci-lint
branch
9 times, most recently
from
eb99719 to
7fd68b9
Compare
jmank88
force-pushed
the
golangci-lint
branch
from
7fd68b9 to
2c67634
Compare
jmank88
force-pushed
the
golangci-lint
branch
from
2c67634 to
d4458ba
Compare
jmank88
requested review from
jkongie,
samsondav,
a team,
connorwstein,
prashantkumar1982,
krehermann and
RyanRHall
as code owners
jmank88
changed the title
|
SonarQube Quality Gate
|
vyzaldysanchez
approved these changes
Jan 11, 2024
samsondav
approved these changes
Jan 11, 2024
| @@ -150,6 +150,7 @@ func (o *orm) CreateBridgeType(bt *BridgeType) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| defer stmt.Close() | |||
krehermann
approved these changes
Jan 11, 2024
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables some new linters and removes an unused file.