add TLS ignore in order to connect to CRIB, add debug #1088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary solution to unblock testing CRIBs with RPC chaos (Geth, Anvil)
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes enhance the RPC client and miner functionalities within a blockchain testing framework, introducing HTTP header support for RPC client requests and adjusting the miner to accept HTTP headers. These modifications aim to improve flexibility in interacting with blockchain nodes for testing purposes, allowing for more precise control over the test environment setup, including security and debug configurations.
What
client/miner.go
http
import to support HTTP operations.NewRemoteAnvilMiner
function to accepthttp.Header
as a parameter, enabling the passing of custom HTTP headers during miner initialization.client/rpc.go
crypto/tls
,net/http
, andos
to support new features.NewRPCClient
to accepthttp.Header
andisDebug
flag from environment variableRESTY_DEBUG
, enhancing the client with HTTP headers and debug mode based on environment settings.InsecureSkipVerify: true
to bypass certificate validation, noted with a TODO to implement proper certificate handling in the future.client/rpc_suite_test.go & client/rpc_test.go
NewRPCClient
andNewRemoteAnvilMiner
to comply with the new signature that includes thehttp.Header
parameter, passingnil
for tests that do not require custom headers. This change ensures that the test suite remains compatible with the updated functions.