Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCF-3269] - Add unimplemented Chain Reader BatchGetLatestValues placeholders #764

Merged
merged 6 commits into from
Jul 12, 2024
Merged

[BCF-3269] - Add unimplemented Chain Reader BatchGetLatestValues placeholders #764

merged 6 commits into from
Jul 12, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Jun 27, 2024 •
edited
Loading

core ref: 14ade151fb28fbd072b8570786ccf8514b649eb7

Related:
Ticket
Core
Common

@ilija42 ilija42 requested review from a team as code owners June 27, 2024 16:18
@ilija42 ilija42 mentioned this pull request Jun 27, 2024
Merged
@ilija42 ilija42 mentioned this pull request Jun 27, 2024
Merged
@ilija42 ilija42 force-pushed the BCF-3269-batch-getlatestvalue branch from 3b34e8e to 009e7e4 Compare June 27, 2024 16:24
@ilija42 ilija42 force-pushed the BCF-3269-batch-getlatestvalue branch from 009e7e4 to 418ec4d Compare June 28, 2024 11:20
@ilija42 ilija42 force-pushed the BCF-3269-batch-getlatestvalue branch from 418ec4d to d2bce83 Compare June 28, 2024 13:18
aalu1418
aalu1418 reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! can we merge the common PR first so we can have the updated commit hash in solana?

@ilija42 ilija42 changed the title [BCF-3269] - Add unimplemented Chain Reader BatchGetLatestValue placeholders [BCF-3269] - Add unimplemented Chain Reader BatchGetLatestValues placeholders Jul 2, 2024
ilija42 added 2 commits July 12, 2024 11:51
@ilija42
Merge remote-tracking branch 'origin/develop' into BCF-3269-batch-get…
42e23c0 
…latestvalue

# Conflicts:
#	go.mod
#	go.sum
#	integration-tests/go.mod
#	integration-tests/go.sum
#	pkg/solana/chainreader/chain_reader_test.go
@ilija42
Bump common and integration tests
e56d2f1
@ilija42 ilija42 requested a review from aalu1418 July 12, 2024 10:15
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit 267a37c into develop Jul 12, 2024
27 of 28 checks passed
@aalu1418 aalu1418 deleted the BCF-3269-batch-getlatestvalue branch July 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilija42 @aalu1418