-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1693] reusable Solidity Review Artifact workflow #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofel
force-pushed
the
tt_1693_reusable_solidity_artifact_workflow
branch
from
September 18, 2024 11:58
a18e46a
to
99c2209
Compare
Tofel
force-pushed
the
tt_1693_reusable_solidity_artifact_workflow
branch
from
September 18, 2024 12:07
99c2209
to
92e2e0c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a reusable Solidity Review Artifact generating pipeline that currently was stored in
chainlink
repository.I have made it more universal, so that it's possible to use with repositories that use different project structure (
chainlink
repo is very specific in that regard).I have tested it with typical Foundry layout and it works like a charm. Here's a working example: https://github.com/smartcontractkit/solidity-review-artifacts-example that also describes how to use this pipeline in any repository.
Apart from the workflow itself I had to move a couple of scripts and actions:
chainlink
repository workflows)You can find some sample executions here: https://github.com/smartcontractkit/solidity-review-artifacts-example/actions/workflows/solidity-review-artifacts.yml