Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/logger: add SugaredLogger methods #290

Merged
merged 1 commit into from
Dec 13, 2023
Merged

pkg/logger: add SugaredLogger methods #290

merged 1 commit into from
Dec 13, 2023

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Dec 13, 2023 •
edited
Loading

This PR adds three methods to logger.SugaredLogger to enable chaining calls instead of wrapping helpers.

Supports:

@jmank88 jmank88 mentioned this pull request Dec 13, 2023
Merged
@jmank88 jmank88 requested a review from dimriou December 13, 2023 13:33
@jmank88 jmank88 marked this pull request as ready for review December 13, 2023 13:33
@jmank88 jmank88 requested a review from krebernisak as a code owner December 13, 2023 13:33
@jmank88 jmank88 merged commit b6c433e into main Dec 13, 2023
7 of 8 checks passed
@jmank88 jmank88 deleted the sugared-logger-2 branch December 13, 2023 13:45
samsondav pushed a commit that referenced this pull request Jan 11, 2024
@jmank88 @samsondav
pkg/logger: add SugaredLogger methods (#290)
b29134c
ettec pushed a commit that referenced this pull request Mar 28, 2024
@jmank88 @ettec
pkg/logger: add SugaredLogger methods (#290)
8df1a04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimriou dimriou dimriou approved these changes

@poopoothegorilla poopoothegorilla poopoothegorilla approved these changes

@krebernisak krebernisak Awaiting requested review from krebernisak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @poopoothegorilla @dimriou