Chain cursing e2e test - Verifier side #314
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carte7000
reviewed
Nov 13, 2025
| require.NoError(t, err) | ||
|
|
||
| l.Info().Msg("Asserting baseline message reaches verifier but gets dropped due to global curse") | ||
| testCtx.AssertMessageReachedAndDroppedInVerifier(messageID01, 100*time.Second) |
Contributor
There was a problem hiding this comment.
Is there a plan to also add test that shows how we recover those message once the curse is lifted?
Contributor
Author
There was a problem hiding this comment.
I think this replay features e2e tests should be part of M3
CC @makramkd
asoliman92
force-pushed
the
asoliman/chain-curse-e2e-test
branch
from
8782f5a to
1f90f75
Compare
|
Code coverage report:
|
E2E Smoke Test Results
Full logs are available in the workflow artifacts. |
makramkd
requested changes
Nov 14, 2025
Comment on lines
+135
to
+139
| // ApplyCurse applies a curse to the specified subjects on the given chain. | ||
| ApplyCurse(ctx context.Context, chainSelector uint64, subjects [][16]byte) error | ||
|
|
||
| // ApplyUncurse removes a curse from the specified subjects on the given chain. | ||
| ApplyUncurse(ctx context.Context, chainSelector uint64, subjects [][16]byte) error |
Collaborator
There was a problem hiding this comment.
These can just be Curse and Uncurse as they are already verbs
Comment on lines
+1701
to
+1714
| rmnRemoteAddr, err := m.getRMNRemoteAddress(chainSelector) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| ethClient, ok := m.ethClients[chainSelector] | ||
| if !ok { | ||
| return fmt.Errorf("eth client not found for chain %d", chainSelector) | ||
| } | ||
|
|
||
| rmnRemote, err := rmn_remote_binding.NewRMNRemote(rmnRemoteAddr, ethClient) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create RMN Remote contract binding: %w", err) | ||
| } |
Collaborator
There was a problem hiding this comment.
Pull this out into a private helper method getRMNRemote so that you can use from the Curse and Uncurse methods
| return fmt.Errorf("deployer key not found for chain %d", chainSelector) | ||
| } | ||
|
|
||
| // Set context for transaction |
| Uint64("chain", chainSelector). | ||
| Str("tx", tx.Hash().Hex()). | ||
| Int("numSubjects", len(subjects)). | ||
| Msg("Applied curse on chain") |
Collaborator
There was a problem hiding this comment.
Suggested change
| Msg("Applied curse on chain") | |
| Msg("Cursed subjects on chain") |
| m.logger.Info(). | ||
| Uint64("chain", chainSelector). | ||
| Str("tx", tx.Hash().Hex()). | ||
| Int("numSubjects", len(subjects)). |
Collaborator
There was a problem hiding this comment.
Nit: The subjects are pertinent to this function, would be nice to see them (maybe as uint64's and not [16]byte)
| chain0, chain1, chain2 := selectors[0], selectors[1], selectors[2] | ||
| receiver := mustGetEOAReceiverAddress(t, c, chain1) | ||
|
|
||
| sentEvt := testCtx.MustSendMessage(chain0, chain1, receiver, 150) // Use custom finality to slow down picking for verification |
Collaborator
There was a problem hiding this comment.
This has the makings of a flakey test because if we somehow speed up the mining even more this test may start randomly failing?
More effective would be to use an env.toml file that doesn't have super fast finality?
Comment on lines
+750
to
+754
| // We sleep here because in reality we'll need to replay events in case of curses to pick up the dropped tasks | ||
| // Increased wait time for CI environments where services may need more time to catch up | ||
| time.Sleep(15 * time.Second) | ||
|
|
||
| testCtx.MustExecuteMessage(chain0, chain1, receiver, 0) // finality=0 |
Collaborator
There was a problem hiding this comment.
So what happens to sentEvt, this first message sent in this test?
Comment on lines
+734
to
+735
| l.Info().Msg("Asserting baseline message reaches verifier but gets dropped due to curse") | ||
| testCtx.AssertMessageReachedAndDroppedInVerifier(messageID, 100*time.Second) |
Collaborator
There was a problem hiding this comment.
Feels like we need to come up with a better way to assert things like this more than ever, since this is a pretty long timeout (longer than half the other tests in TestSmoke combined)
Comment on lines
+82
to
+88
| // DefaultMessageFields creates a simple message with test data. | ||
| func DefaultMessageFields(receiver protocol.UnknownAddress) cciptestinterfaces.MessageFields { | ||
| return cciptestinterfaces.MessageFields{ | ||
| Receiver: receiver, | ||
| Data: []byte("test-msg"), | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Doesn't need to be exported
| // MustSendMessage sends a message and waits for the sent event. | ||
| // If finality is 0, uses version 2 (no finality config). | ||
| // If finality is non-zero, uses version 3 with the specified finality config. | ||
| func (tc *TestingContext) MustSendMessage(srcChain, destChain uint64, receiver protocol.UnknownAddress, finality uint16) cciptestinterfaces.MessageSentEvent { |
Collaborator
There was a problem hiding this comment.
I'd really like to not have these helpers - feels like this could be part of the top-level interface instead.
Collaborator
There was a problem hiding this comment.
You can define DefaultMessageFields as a test-local thing instead of something thats hardcoded in the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.