From 4ca496152e7c1a59de106ad32fff5b1dab531400 Mon Sep 17 00:00:00 2001
From: Daniel <dm@tpwd.de>
Date: Wed, 25 Sep 2024 17:12:38 +0200
Subject: [PATCH] fix(normalize): for landscape and add caching

SVA-1348
---
 src/config/normalize.js | 46 ++++++++++++++++++++++++++++++-----------
 1 file changed, 34 insertions(+), 12 deletions(-)

diff --git a/src/config/normalize.js b/src/config/normalize.js
index 403a2e3bd..dbbb71226 100644
--- a/src/config/normalize.js
+++ b/src/config/normalize.js
@@ -1,14 +1,36 @@
 import { Dimensions, PixelRatio } from 'react-native';
 
-// Default guideline sizes are based on standard ~6.12" screen mobile device (iPhone 15 Pro)
-const guidelineBaseWidth = 393;
-const guidelineBaseHeight = 852;
-
-export const normalize = (size, factor = 1) => {
-  const { width, height } = Dimensions.get('window');
-  const widthScale = width / guidelineBaseWidth;
-  const heightScale = height / guidelineBaseHeight;
-  const scale = Math.min(widthScale, heightScale);
-
-  return PixelRatio.roundToNearestPixel(size * scale * factor);
-};
+// Default sizes are based on standard ~6.12" portrait screen mobile device (iPhone 15 Pro)
+const GUIDELINE_BASE_WIDTH_PORTRAIT = 393;
+const GUIDELINE_BASE_HEIGHT_PORTRAIT = 852;
+
+/**
+ * Normalize sizes based on the screen and orientation and
+ * cache the results to avoid recalculations every time
+ */
+export const normalize = (() => {
+  const cache = new Map();
+
+  return (size, factor = 1) => {
+    const { width, height } = Dimensions.get('window');
+    const isLandscape = width > height;
+    const cacheKey = `${size}-${factor}-${width}-${height}-${
+      isLandscape ? 'landscape' : 'portrait'
+    }`;
+
+    if (cache.has(cacheKey)) {
+      return cache.get(cacheKey);
+    }
+
+    const widthScale =
+      width / (isLandscape ? GUIDELINE_BASE_HEIGHT_PORTRAIT : GUIDELINE_BASE_WIDTH_PORTRAIT);
+    const heightScale =
+      height / (isLandscape ? GUIDELINE_BASE_WIDTH_PORTRAIT : GUIDELINE_BASE_HEIGHT_PORTRAIT);
+    const scale = Math.min(widthScale, heightScale);
+    const normalizedSize = PixelRatio.roundToNearestPixel(size * scale * factor);
+
+    cache.set(cacheKey, normalizedSize);
+
+    return normalizedSize;
+  };
+})();