Refactor security settings application in mcpproxy to only apply changes if explicitly set via command line flags. Update logging level for removed server menu items from Info to Debug in tray manager.

Author: Dumbris

cmd/mcpproxy/main.go

@@ -252,19 +252,31 @@ func runServer(cmd *cobra.Command, _ []string) error {
 		cfg.ToolResponseLimit = cmdToolResponseLimit
 	}
 
-	// Apply security settings from command line
-	cfg.ReadOnlyMode = cmdReadOnlyMode
-	cfg.DisableManagement = cmdDisableManagement
-	cfg.AllowServerAdd = cmdAllowServerAdd
-	cfg.AllowServerRemove = cmdAllowServerRemove
-	cfg.EnablePrompts = cmdEnablePrompts
+	// Apply security settings from command line ONLY if explicitly set
+	if cmd.Flags().Changed("read-only") {
+		cfg.ReadOnlyMode = cmdReadOnlyMode
+	}
+	if cmd.Flags().Changed("disable-management") {
+		cfg.DisableManagement = cmdDisableManagement
+	}
+	if cmd.Flags().Changed("allow-server-add") {
+		cfg.AllowServerAdd = cmdAllowServerAdd
+	}
+	if cmd.Flags().Changed("allow-server-remove") {
+		cfg.AllowServerRemove = cmdAllowServerRemove
+	}
+	if cmd.Flags().Changed("enable-prompts") {
+		cfg.EnablePrompts = cmdEnablePrompts
+	}
 
 	logger.Info("Configuration loaded",
 		zap.String("data_dir", cfg.DataDir),
 		zap.Int("servers_count", len(cfg.Servers)),
 		zap.Bool("tray_enabled", cfg.EnableTray),
 		zap.Bool("read_only_mode", cfg.ReadOnlyMode),
 		zap.Bool("disable_management", cfg.DisableManagement),
+		zap.Bool("allow_server_add", cfg.AllowServerAdd),
+		zap.Bool("allow_server_remove", cfg.AllowServerRemove),
 		zap.Bool("enable_prompts", cfg.EnablePrompts))
 
 	// Create server

internal/tray/managers.go

@@ -347,7 +347,7 @@ func (m *MenuManager) UpdateUpstreamServersMenu(servers []map[string]interface{}
 		// Hide servers that are no longer in the config
 		for serverName, menuItem := range m.serverMenuItems {
 			if _, exists := currentServerMap[serverName]; !exists {
-				m.logger.Info("Hiding menu item for removed server", zap.String("server", serverName))
+				m.logger.Debug("Hiding menu item for removed server", zap.String("server", serverName))
 				menuItem.Hide()
 				// Also hide its sub-menu items if they exist
 				if actionItem, ok := m.serverActionItems[serverName]; ok {