Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record timer details and enable validation tests for record&replay #371

Open
smarr opened this issue Aug 11, 2020 · 0 comments
Open

Record timer details and enable validation tests for record&replay #371

smarr opened this issue Aug 11, 2020 · 0 comments
Labels
enhancement Improves the implementation with something noteworthy

Comments

@smarr
Copy link
Owner

smarr commented Aug 11, 2020

The new uniform record&replay (#337) does not yet handle external events, including the timer.

We essentially need to reimplement the timer using the new tracing infrastructure in TracingActivityThread.

This will allow us to reenable the validation tests here: https://github.com/smarr/SOMns/pull/337/files#diff-f1dab3cc0c0b97293c62c8db275d5793R118
@smarr smarr added the enhancement Improves the implementation with something noteworthy label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improves the implementation with something noteworthy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smarr