調べるのブロックをRubyに変換できるようにしました。 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

takaokouji merged 4 commits into smalruby:develop from t-kazu:feature/sensing-blocks

Oct 23, 2018

Collaborator

t-kazu commented Oct 23, 2018

No description provided.

t-kazu added 2 commits

October 23, 2018 13:13


          sensingの命令ブロックをRubyに変換できるようにしました

b03c210


          関数名等を修正しました

5c69e7b

takaokouji reviewed

View reviewed changes

src/lib/ruby-generator/sensing.js Outdated Show resolved Hide resolved

takaokouji reviewed

View reviewed changes

src/lib/ruby-generator/sensing.js Outdated Show resolved Hide resolved

takaokouji reviewed

View reviewed changes

src/lib/ruby-generator/sensing.js Outdated Show resolved Hide resolved

takaokouji commented Oct 23, 2018

一通り確認してコメントしたので修正をお願いします。


          propertyの名前を変換します

d8a6292

Collaborator Author

t-kazu commented Oct 23, 2018

修正しました。propertyToMethod はとりあえずこちらで決めました。
問題あればコメントお願いします

takaokouji reviewed

View reviewed changes

src/lib/ruby-generator/sensing.js Outdated Show resolved Hide resolved

takaokouji reviewed

View reviewed changes

src/lib/ruby-generator/sensing.js Outdated Show resolved Hide resolved

takaokouji commented Oct 23, 2018

コメントしました。たびたびですが、修正をお願いします 🙇

Collaborator Author

t-kazu commented Oct 23, 2018

こちらこそよく確認しておらず申し訳ございません。修正致します。


          返り値とオブジェクトの定義位置を変更しました

672f6a6

Collaborator Author

t-kazu commented Oct 23, 2018

度々申し訳ございません。修正致しました。ご確認お願い致します

takaokouji commented Oct 23, 2018

LGTM

takaokouji merged commit 319b3b4 into smalruby:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet