scratch guiをマージしました #139
Merged
scratch guiをマージしました #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses randomized duration between [0, 2^k-1] where k is the connection attempt number, maxed out at 5. I had to rework the tests quite a bit to make this easy to test, to work around the timeouts and the randomization.
…ared out appropriately. This fixes a bug where we were making two cloud connections when creating a new project and not clearing out previous connections when switching between editor and preview/player mode.
…t Json parse errors because of a newline being at the end of the message. Add test that fails without the bugfix.
…use of a project id change. isShowingWithId must also be true.
This will work better if there are other query string options that need to be handled later. It also handles the distinction between ‘all’ and the other tutorials better.
…-z-index moved z-index of alerts down around modal, loader levels
…nto reconnect-cloud
more font options for creator, besides only "Helvetica Neue"
…ver. Add unit test for disconnecting on unmount.
export remixProject reducer function
…efactor-all-tutorials Move URL query string handling into an HOC
Queue up messages to send ot the cloud server which accumulate before the connection is ready. Add tests for new/updated functionality.
…when-has-cloud-data Connect to cloud based on hasCloudData
…isconnect Disconnect from cloud when entering editor mode on someone else's project
…draft autosave periodically when project is dirty
…mbnails Send snapshots from the renderer to be saved as project thumbnails
It was causing a bug where switching tabs and adding a sprite would make the workspace blocks not work. Needs investigation.
…hanging Remove setTimeout for reattaching workspace block listener.
…anslations-first delete existing translations before building translations, to avoid errors
…vise Revise alerts code to clarify and reorganize alert type handling
…re-save-as-copy save before saving as a copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.