Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[step-certificates] Make pod template customizable #86

Open
zerodayyy opened this issue Jan 26, 2022 · 1 comment
Open

[step-certificates] Make pod template customizable #86

zerodayyy opened this issue Jan 26, 2022 · 1 comment

Comments

@zerodayyy
Copy link

In my case, I need to set extra environment variables with Azure credentials to avoid attaching certain roles to the whole Kubernetes node. Also one might need to set labels, annotations (as in #83), provide extra arguments to the binary, mount extra volumes etc.

Usually, Helm charts provide a way to inject these using values, for example see traefik, nginx charts.

It would be great if step-certificates chart provided a way to manipulate pod template without the need to fork and modify the chart.

@maraino maraino added the needs triage Waiting for discussion / prioritization by team label Feb 17, 2022
@maraino
Copy link
Collaborator

maraino commented Feb 23, 2022

Hi @zerodayyy, using the last version from the master branch you can already inject environment variables like Azure credentials. See:

{{- if .Values.ca.env }}
{{- toYaml .Values.ca.env | nindent 10 }}
{{- end }}

Regarding labels, annotations, volumes, ... all of them can be added. Some of our projects already support some those extra configurations.

And of course, we would appreciate PRs adding support to some of these.

PS: Let me know if you need a new release of the step-certificates chart to add the new environment variables.

@dopey dopey removed the needs triage Waiting for discussion / prioritization by team label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants