Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace streams with for loop in customizers handling #1274

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 20, 2024

This isn't going to make any difference in real life, but it does at least make stacktraces look
a little better to look at
(when an exception is thrown or in a flamegraph)

Theoretically this change does change the semantics slightly as the customizers array is now sorted, but these customizers are private, so it shouldn't matter

This isn't going to make any difference in real life,
but it does at least make stacktraces look
a little better to look at
(when an exception is thrown or in a flamegraph)

Theoretically this change does change the semantics slightly
as the customizers array is now sorted, but these customizers
are private, so it shouldn't matter
@radcortez
Copy link
Member

Thanks!

@radcortez radcortez merged commit 220be74 into smallrye:main Dec 20, 2024
8 checks passed
@github-actions github-actions bot added this to the 3.10.3 milestone Dec 20, 2024
@geoand
Copy link
Contributor Author

geoand commented Dec 20, 2024

🙏

@geoand geoand deleted the builder-customizers branch December 20, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants