Skip to content

Commit 9993228

Browse files
Fix web_ui warnings flagged by the next Dart analyzer update (flutter#20524)
1 parent 0cda293 commit 9993228

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

lib/web_ui/lib/src/engine/compositor/shader.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ class CkImageShader extends CkShader implements ui.ImageShader {
173173
SkShader createDefault() => _skImage.skImage.makeShader(
174174
toSkTileMode(tileModeX),
175175
toSkTileMode(tileModeY),
176-
matrix4 != null ? toSkMatrixFromFloat64(matrix4) : null,
176+
toSkMatrixFromFloat64(matrix4),
177177
);
178178

179179
@override

lib/web_ui/lib/src/engine/surface/scene_builder.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,6 @@ class SurfaceSceneBuilder implements ui.SceneBuilder {
7878
Float64List matrix4, {
7979
ui.TransformEngineLayer? oldLayer,
8080
}) {
81-
if (matrix4 == null) { // ignore: unnecessary_null_comparison
82-
throw ArgumentError('"matrix4" argument cannot be null');
83-
}
8481
if (matrix4.length != 16) {
8582
throw ArgumentError('"matrix4" must have 16 entries.');
8683
}

lib/web_ui/test/engine/surface/scene_builder_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ void main() {
5656
testLayerLifeCycle((SceneBuilder sceneBuilder, EngineLayer oldLayer) {
5757
return sceneBuilder.pushClipRRect(
5858
RRect.fromLTRBR(10, 20, 30, 40, const Radius.circular(3)),
59-
oldLayer: oldLayer);
59+
oldLayer: oldLayer,
60+
clipBehavior: Clip.none);
6061
}, () {
6162
return '''
6263
<s>

lib/web_ui/test/text/measurement_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1157,5 +1157,6 @@ EngineLineMetrics line(
11571157
lineNumber: lineNumber,
11581158
left: left,
11591159
endIndexWithoutNewlines: -1,
1160+
widthWithTrailingSpaces: width,
11601161
);
11611162
}

0 commit comments

Comments
 (0)