Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gotemplate grammar (as external grammar) #104

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

qvalentin
Copy link
Contributor

Hi, awesome project :D.
I am planning on using this grammar for https://github.com/mrjosh/helm-ls, so it would be cool if it could be included in this repo.

@smacker
Copy link
Owner

smacker commented May 1, 2023

Hello! I guess go template is not very commonly used grammar.

Do you think you could publish it in a separate repository instead?

Similar to https://github.com/aheber/tree-sitter-sfapex and https://github.com/shagabutdinov/go-tree-sitter-ruby (the second repository is deprecated as Ruby grammar was moved to the main repo)

I'll be happy to update README to include your repository in the list of custom grammars.

@qvalentin
Copy link
Contributor Author

Thanks for the answer. I'm fine with publishing it as a fork. I can propose a PR for updating the README, once i figured out the best way to setup the fork.

@smacker
Copy link
Owner

smacker commented May 1, 2023

@qvalentin to clarify: you don't need a fork. Just publish the grammar aka content of gotemplate directory you created as a separate repository, e.g. github.com/qvalentin/go-tree-sitter-gotemplate. You can continue using github.com/smacker/go-tree-sitter for the tree-sitter binding and any other grammars we have here.

@qvalentin qvalentin changed the title Add gotemplate grammar Add gotemplate grammar (als external grammar) Jul 31, 2023
@qvalentin qvalentin changed the title Add gotemplate grammar (als external grammar) Add gotemplate grammar (as external grammar) Jul 31, 2023
@smacker smacker merged commit 06670b6 into smacker:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants