Skip to content

Add device-tree for Samsung Galaxy A71 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add device-tree for Samsung Galaxy A71 #2

wants to merge 1 commit into from

Conversation

@WiiPlayer2
Copy link

@WiiPlayer2 WiiPlayer2 commented Apr 3, 2025

No description provided.

@SanyaPilot
Copy link

SanyaPilot commented Apr 4, 2025

I think you should squash all your commits to one, this looks messy

@WiiPlayer2
Copy link
Author

WiiPlayer2 commented Apr 4, 2025

I think you should squash all your commits to one, this looks messy

Is this really necessary? Doesn't GitHub support squash merges? Or is there another reason?

@SanyaPilot
Copy link

SanyaPilot commented Apr 4, 2025 •
edited
Loading

I think you should squash all your commits to one, this looks messy

Is this really necessary? Doesn't GitHub support squash merges? Or is there another reason?

Yea, GitHub supports squash merges, but it's just cleaner when you send a properly formed commit

@Gelbpunkt Gelbpunkt force-pushed the master branch 2 times, most recently from 4a7f216 to 70c600c Compare April 14, 2025 01:52
@Gelbpunkt Gelbpunkt force-pushed the master branch 7 times, most recently from eb4235a to 0f36c4a Compare April 30, 2025 17:24
@manigohan
Copy link

manigohan commented May 18, 2025

sorry for necroposting, this looks fine enough but commit message should be

dts: upstream: arm64: qcom: Add devicetree for Samsung Galaxy A71

also, fix conflicts

@WiiPlayer2
Copy link
Author

WiiPlayer2 commented May 19, 2025

sorry for necroposting, this looks fine enough but commit message should be

dts: upstream: arm64: qcom: Add devicetree for Samsung Galaxy A71

also, fix conflicts

Currently waiting for sm7150-mainline/linux#44 to be merged. After that is being done, I'll copy the dts again and will fix the commit message as well.

@WiiPlayer2 WiiPlayer2 marked this pull request as draft May 19, 2025 07:50
Gelbpunkt pushed a commit that referenced this pull request Aug 13, 2025
@DragonBluep @trini
env: mtd: add the missing put_mtd_device()
39ae954 
The mtd device is got in setup_mtd_device(), we must put the mtd
device before exiting the function to update the mtd use count.
This patch fixes the following env error:

> Removing MTD device #2 (u-boot-env) with use count 1
> Error when deleting partition "u-boot-env" (-16)

Fixes: 03fb08d ("env: Introduce support for MTD")
Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
@Gelbpunkt Gelbpunkt force-pushed the master branch 4 times, most recently from d135c8e to e9a42fd Compare August 30, 2025 22:44
@Gelbpunkt Gelbpunkt force-pushed the master branch 2 times, most recently from 0e292eb to 3697a53 Compare September 24, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WiiPlayer2 @SanyaPilot @manigohan