Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: v.2.0.0: finalize CHANGELOG.md #3577

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

ramonpetgrave64
Copy link
Collaborator

@ramonpetgrave64 ramonpetgrave64 commented Apr 18, 2024

Summary

#3576

First step before a release, marking all "Unreleased" changes in CHANGELOG.md as "v2.0.0"

Testing Process

...

Checklist

  • Review the contributing guidelines
  • Add a reference to related issues in the PR description.
  • Update documentation if applicable.
  • Add unit tests if applicable.
  • Add changes to the CHANGELOG if applicable.

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64 ramonpetgrave64 changed the title finalize changelog docs: finalize CHANGELOG.md Apr 18, 2024
@ramonpetgrave64 ramonpetgrave64 changed the title docs: finalize CHANGELOG.md docs: v.1.11.0: finalize CHANGELOG.md Apr 18, 2024
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review April 18, 2024 16:56
@ramonpetgrave64
Copy link
Collaborator Author

@laurentsimon

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@laurentsimon
Copy link
Collaborator

laurentsimon commented Apr 18, 2024

Should this be a major bump, since we already removed the deprecated option attestation-name https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/workflows/generator_generic_slsa3.yml#L59-L62? Or do you want to revert these and cut v1.11.0?

I'm fine reverting to speed things up and not worry about possible other breaking changes we were thinking of adding.

@ramonpetgrave64
Copy link
Collaborator Author

I thin we should do the major version bump. I'll edit the bump to 2.0.0

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64 ramonpetgrave64 changed the title docs: v.1.11.0: finalize CHANGELOG.md docs: v.2.0.0: finalize CHANGELOG.md Apr 18, 2024
@ramonpetgrave64 ramonpetgrave64 merged commit 3789345 into main Apr 18, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants