Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Remove the pkg directory in Go builder #607

Open
laurentsimon opened this issue Jul 21, 2022 · 5 comments
Open

[feature] Remove the pkg directory in Go builder #607

laurentsimon opened this issue Jul 21, 2022 · 5 comments
Assignees
Labels
area:go Issue related to the Go ecosystem status:help wanted Extra attention is needed type:refactor A cleanup or refactor

Comments

@laurentsimon
Copy link
Collaborator

The pkg directory serves no purpose, let's flatten the directory structure like the generic builder does.

@laurentsimon laurentsimon added the type:refactor A cleanup or refactor label Jul 21, 2022
@laurentsimon laurentsimon self-assigned this Jul 21, 2022
@ianlewis ianlewis added area:go Issue related to the Go ecosystem status:help wanted Extra attention is needed labels Jul 22, 2022
@naveensrinivasan
Copy link
Collaborator

The pkg directory serves no purpose, let's flatten the directory structure like the generic builder does.

Can you please explain as to why ?

It usually provides functionality that can be reused and helps with separation of concerns and cleaner code.

@laurentsimon
Copy link
Collaborator Author

we don't expose API to anyone, it's all internal. Right now the pkg folder has all the code, so it serves no real purpose. The builder is very simple, so file separation is enough. We could have folder for each file / logic instead, but its overkill and complicates more than it helps.

@naveensrinivasan
Copy link
Collaborator

OK.Why aren't we planning to expose the API? Is there a specific reason?

@laurentsimon
Copy link
Collaborator Author

laurentsimon commented Jul 27, 2022

It's our native builder and provides only the features we need. Also, it adds burden on versioning for us, and there does not seem to be a case for public APIs at this point.

But this can always be re-visited later. Right now it's not a priority for us.

@naveensrinivasan
Copy link
Collaborator

But this can always be re-visited later. Right now it's not a priority for us.

Agreed. Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:go Issue related to the Go ecosystem status:help wanted Extra attention is needed type:refactor A cleanup or refactor
Projects
None yet
Development

No branches or pull requests

3 participants