Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] draft releases support for uploading provenance #1862

Closed
developer-guy opened this issue Mar 22, 2023 · 1 comment
Closed

[feature] draft releases support for uploading provenance #1862

developer-guy opened this issue Mar 22, 2023 · 1 comment
Labels
status:duplicate This issue or pull request already exists type:feature New feature or request

Comments

@developer-guy
Copy link
Contributor

developer-guy commented Mar 22, 2023

Is your feature request related to a problem? Please describe.
This might be related to a problem but at the same time, this is a feature.

Describe the solution you'd like
While working on the osv-scanner project, I realized that they mark their release as a draft for some reason. In that case, if we set the upload-assets parameter of the Generic SLSA 3 Generator as true, we see two different releases with the same tag, one is marked as draft the other is marked as latest. Then I dag into the problem a bit, and noticed that the Generic SLSA 3 Generator uses soft-props/action-gh-release to upload the provenance file, here and here. There is a draft option available in the parameters of the action-gh-release GitHub Action.

So, maybe we can add a new parameter to these generators for people who might want to mark their release as a draft, if so, they can pass that parameter to the action-gh-release to avoid having duplicate releases.

PTAL @laurentsimon

@developer-guy developer-guy added status:triage Issue that has not been triaged type:feature New feature or request labels Mar 22, 2023
@ianlewis ianlewis added status:duplicate This issue or pull request already exists and removed status:triage Issue that has not been triaged labels Mar 22, 2023
@ianlewis
Copy link
Member

I think this is the same as #1476? Could you maybe comment on #1476 about osv-scanner?

I'll go ahead and close this and defer to that issue but feel free to re-open if you think there is more that should be covered in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:duplicate This issue or pull request already exists type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants