Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Fix builderInvocationId validation #1848

Open
ianlewis opened this issue Mar 20, 2023 · 0 comments
Open

[feature] Fix builderInvocationId validation #1848

ianlewis opened this issue Mar 20, 2023 · 0 comments
Labels
area:BYOB An issue with the BYOB framework area:nodejs Issue related to the Node.js builder type:feature New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented Mar 20, 2023 •
edited
Loading

Currently npmjs.com validates the builderInvocationId is of the form:

<environment.GITHUB_RUN_ID>-<environment.GITHUB_RUN_ATTEMPT>

This is likely based on how we had set the builderInvocationId on our previous builders, prior to BYOB.

The exact value should be based on the builder.id. The nodejs builder specifies a different builder.id but this value is still validated. We'd like to set this to a URI that makes it easier to find the build run's logs etc.
@ianlewis ianlewis added type:feature New feature or request area:nodejs Issue related to the Node.js builder area:BYOB An issue with the BYOB framework labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:BYOB An issue with the BYOB framework area:nodejs Issue related to the Node.js builder type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianlewis