Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] prerelease check list #1801

Closed
1 of 3 tasks
laurentsimon opened this issue Mar 10, 2023 · 6 comments · Fixed by #1830
Closed
1 of 3 tasks

[feature] prerelease check list #1801

laurentsimon opened this issue Mar 10, 2023 · 6 comments · Fixed by #1830
Labels
area:go Issue related to the Go ecosystem type:feature New feature or request

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented Mar 10, 2023 •
edited by asraa
Loading

Before releasing this feature e2e tests for prerelease support

  • add 1 e2e test
  • Update the documentation
  • Add a changelog entry
@laurentsimon laurentsimon added type:feature New feature or request status:triage Issue that has not been triaged labels Mar 10, 2023
@laurentsimon laurentsimon changed the title [feature] e2e tests for prerelease support [feature] prerelease check list Mar 10, 2023
@laurentsimon laurentsimon added go Pull requests that update Go code and removed status:triage Issue that has not been triaged labels Mar 10, 2023
@ianlewis
Copy link
Member

Could we just add this is tasks to complete #1795?

@ianlewis ianlewis added area:go Issue related to the Go ecosystem and removed go Pull requests that update Go code labels Mar 13, 2023
@asraa
Copy link
Collaborator

asraa commented Mar 14, 2023

e2e test created: https://github.com/slsa-framework/example-package/blob/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml

@asraa
Copy link
Collaborator

asraa commented Mar 14, 2023

The other items are tackled here: #1822

@laurentsimon
Copy link
Collaborator Author

e2e test created: https://github.com/slsa-framework/example-package/blob/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml

do we verify the release is marked pre-release in the verification part?

@asraa
Copy link
Collaborator

asraa commented Mar 14, 2023

do we verify the release is marked pre-release in the verification part?

can add that - i just looked at manually but that shouldn't be hard

@asraa
Copy link
Collaborator

asraa commented Mar 14, 2023

do we verify the release is marked pre-release in the verification part?

done - slsa-framework/example-package@f19de18

@laurentsimon laurentsimon mentioned this issue Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:go Issue related to the Go ecosystem type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: prerelease doc and CHANGELOG updates for Go builder laurentsimon/slsa-github-generator
3 participants
@ianlewis @asraa @laurentsimon