Skip to content

Commit 1d60541

Browse files
ramosian-glidertorvalds
authored andcommitted
fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()
KMSAN reported uninitialized data being written to disk when dumping core. As a result, several kilobytes of kmalloc memory may be written to the core file and then read by a non-privileged user. Reported-by: sam <sunhaoyl@outlook.com> Signed-off-by: Alexander Potapenko <glider@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Kees Cook <keescook@chromium.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: <stable@vger.kernel.org> Link: http://lkml.kernel.org/r/20200419100848.63472-1-glider@google.com Link: google/kmsan#76 Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 6988f31 commit 1d60541

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/binfmt_elf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1733,7 +1733,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
17331733
(!regset->active || regset->active(t->task, regset) > 0)) {
17341734
int ret;
17351735
size_t size = regset_size(t->task, regset);
1736-
void *data = kmalloc(size, GFP_KERNEL);
1736+
void *data = kzalloc(size, GFP_KERNEL);
17371737
if (unlikely(!data))
17381738
return 0;
17391739
ret = regset->get(t->task, regset,

0 commit comments

Comments
 (0)