-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default-font-* properties in Live-Preview #7011
base: master
Are you sure you want to change the base?
Conversation
67231b9
to
8d487c2
Compare
No tests? Could you make a test that involve a PopupWindow. I have a suspicion that it may not work because the PopupWindow inject a WindowItem that doesn't define these default-font-* properties. eg: export component TestCase inherits Window {
default-font-size: 140px;
PopupWindow {
// the font size of this text must be large
Text { text: "hello"; }
}
}
`` |
That's an excellent point - this is indeed also not handled (besides the |
1aa3b07
to
e7a04ef
Compare
Rebased to resolve conflicts and to implement the suggested change to to use |
e3871a1
to
e298b56
Compare
463c809
to
b51daf4
Compare
... by changing the resolution for the `WindowItem` to traverse the item tree from the current item, instead of going to the window. This doesn't quite fix #4298 because `rem` resolution is still missing. That requires the built-in default font size function to be fixed as well, which is non-trivial. cc #4298
...through a component factory, as we use that in the live-preview.
b51daf4
to
5c4889c
Compare
PopupWindow fixes are in, as discussed with run-time resolution. |
... by changing the resolution for the
WindowItem
to traverse the item tree from the current item, instead of going to the window.This doesn't quite fix #4298 because
rem
resolution is still missing. That requires the built-in default font size function to be fixed as well, which is non-trivial.cc #4298