-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the latest versions of esp-hal and slint are present simultaneously, a compilation error occurs #5057
Comments
esp-rs/esp-hal#1434 (comment) |
Looks like we shouldn't unconditionally require critical-section in slint/internal/core/Cargo.toml Line 58 in a61ca93
|
Any plan to fix this? It's really annoying that need to patch |
Not sure how to fix this. |
@ogoffart what if we follow the
And user could choose one of them to use. Update:
A breaking and clumsy change, but I can't see any other solution. : ( |
I guess you're right. We can make it non-breaking by using the compat-1-2 feature. In api/rs/slint/Cargo.toml unsafe-single-threaded = []
portable-atomic-single-core = ["portable-atomic/unsafe-assume-single-core"]
portable-atomic-critical-section = ["portable-atomic/critical-section"]
compat-1-2 = ["portable-atomic-critical-section", "compat-1-7"]
compat-1-7 = [] in internal/core/Cargo.toml portable-atomic = { version = "1", features = ["require-cas"] } But we also need to document that properly. (This just makes it even more complicated to setup for MCU apps) |
When the latest versions of
esp-hal
andslint
are present simultaneously, a compilation error occurs:The error message is as follows:
The text was updated successfully, but these errors were encountered: