Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reactions should use abstract names, not icon titles #25

Open
codyzu opened this issue Jul 11, 2023 · 0 comments
Open

reactions should use abstract names, not icon titles #25

codyzu opened this issue Jul 11, 2023 · 0 comments

Comments

@codyzu
Copy link
Collaborator

codyzu commented Jul 11, 2023

reactions should be keyed by their abstract names, i.e. love, smile, lol, etc... This includes when they are broadcast between the views and how they are stored when rendering. Only when they are finally rendered, should they be mapped to icon classes. Today, they are keyed by icon classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codyzu