Skip to content

Commit d536acf

Browse files
javerkukulich
authored andcommitted
Fix DisallowAttributesJoiningSniff for Attribute with trailing comma
1 parent 94fd4f9 commit d536acf

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

SlevomatCodingStandard/Helpers/AttributeHelper.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ public static function getAttributes(File $phpcsFile, int $attributeOpenerPointe
5858

5959
do {
6060
$attributeNameStartPointer = TokenHelper::findNextEffective($phpcsFile, $actualPointer + 1, $attributeCloserPointer);
61+
62+
if ($attributeNameStartPointer === null) {
63+
break;
64+
}
65+
6166
$attributeNameEndPointer = TokenHelper::findNextExcluding(
6267
$phpcsFile,
6368
TokenHelper::getNameTokenCodes(),

tests/Sniffs/Attributes/data/disallowedAttributesJoiningNoErrors.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ public function __construct(#[Attribute1] #[Attribute2('var')]
1515

1616
#[Attribute1] #[Attribute2('var')]
1717
#[Attribute3(option: PDO::class, option2: true, option3: 'False')]
18+
#[Attribute4,]
1819
function testFunc($test)
1920
{
2021
}

0 commit comments

Comments
 (0)