Add requestFileInfo param to MethodsClient#filesUploadV2 method #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
seratch
force-pushed
the
request-file-info-in-files-upload-v2
branch
from
f7e7899 to
6501edd
Compare
Codecov Report
@@ Coverage Diff @@
## main #1081 +/- ##
============================================
+ Coverage 75.95% 75.97% +0.01%
- Complexity 3774 3776 +2
============================================
Files 413 413
Lines 11750 11754 +4
Branches 1152 1153 +1
============================================
+ Hits 8925 8930 +5
Misses 2130 2130
+ Partials 695 694 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seratch
force-pushed
the
request-file-info-in-files-upload-v2
branch
from
6501edd to
480be25
Compare
WilliamBergamin
approved these changes
Nov 8, 2022
Contributor
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Added a nit, but this looks good to me 💯
| underlyingException.getFileInfoResponses().add(fileInfo); | ||
| if (!fileInfo.isOk()) { | ||
| throw underlyingException; | ||
| if (v2Request.isRequestFileInfo()) { |
Contributor
There was a problem hiding this comment.
NIT: I would tend to try and place this in its own function named something like fetchFile that returns the File object from fileInfo.getFile() or partialFileObject
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. In this case, the part won't be reused elsewhere plus we have to pass v2Request
and underlyingException to the internal method, which is not so simple. So, let me go with the current code.
SotaNakajima
pushed a commit
to SotaNakajima/java-slack-sdk
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds requestFileInfo option to MethodsClient#filesUploadV2 method for feature parity with Node and Python SDKs. See the following PRs for its context:
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.