Handle non-JSON 500 errors #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested changes
Jan 26, 2021
agrobbin
force-pushed
the
500-html-response
branch
from
3be1e27
to
982acd4
Compare
agrobbin
changed the title
|
@dblock just updated the CHANGELOG, commit message, and PR title here! |
agrobbin
force-pushed
the
500-html-response
branch
from
982acd4
to
541c421
Compare
|
Merged, thank you for fixing this the "right way" by moving middleware around, too. |
|
@dblock my pleasure, and thanks for the quick review + merge! Looking forward to this getting released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #358.
Consider this WebMock'd request, which is based on a real-world scenario we ran into when the Slack API was down:
Before v0.16 (and #350), this raised a
Faraday::ParsingErrorexception, and after those changes, it raises aSlack::Web::Api::Errors::ParsingErrorexception.Looking further at the tests in #350, it appears while there is a test for
status: 500, body: '{}', and there is a test forstatus: 200, body: '<html></html>, there is no test for the combination of the 2.This adds that test, and makes it pass!