-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more supports for cursor pagination #215
Conversation
21f0059
to
fc8bbe1
Compare
We typically include the API changes here in CHANGELOG, please add. The build is failing, needs 💚 , Aren't the modified files for pagination auto-generated? They should not be altered by hand. |
fc8bbe1
to
9bfb83e
Compare
Let me see. Should the description of this changes in
Excuse me, I had forgot to do |
I see. The modified files are auto-generated by (I had altered them by hands. but these changes were overwritten by the command.) |
CHANGELOG.md
Outdated
@@ -1,6 +1,7 @@ | |||
### 0.11.2 (Next) | |||
|
|||
* Your contribution here. | |||
* [#215](https://github.com/slack-ruby/slack-ruby-client/pull/215): Add more supports for cursor pagination - [@hotwatermorning](https://github.com/hotwatermorning). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this with all the changes in separate items by looking at the diff. For example "Added apps_permissions_users_list
" or "files_info
, ...
now support pagination". Thx.
This looks good. Update the changelog with all the changes and it's good to go. |
9bfb83e
to
a99f742
Compare
Thank you for your kind advice. I fixed the changelog and pushed. How about this? |
Good, merged. Thanks. |
slack-api-ref
and fix some methods inweb/api/endpoints/*.rb
.