Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more supports for cursor pagination #215

Merged
merged 3 commits into from
Aug 18, 2018

Conversation

hotwatermorning
Copy link
Contributor

  • Slack added cursor pagination options for some APIs on Aug 8th.
  • To support cursor pagination for the APIs, update slack-api-ref and fix some methods in web/api/endpoints/*.rb.

@hotwatermorning hotwatermorning changed the title Support pagination Add more supports for cursor pagination Aug 16, 2018
@hotwatermorning hotwatermorning force-pushed the support_pagination branch 2 times, most recently from 21f0059 to fc8bbe1 Compare August 16, 2018 19:18
@dblock
Copy link
Collaborator

dblock commented Aug 16, 2018

We typically include the API changes here in CHANGELOG, please add.

The build is failing, needs 💚 , rubocop -a; rubocop --auto-gen-config.

Aren't the modified files for pagination auto-generated? They should not be altered by hand.

@hotwatermorning
Copy link
Contributor Author

We typically include the API changes here in CHANGELOG, please add.

Let me see. Should the description of this changes in CHANGELOG.md be like this?

[#215](https://github.com/slack-ruby/slack-ruby-client/pull/215): Add cursor pagination support for `groups_list`, `files_info`, `mpim_list`, `reactions_list`, `stars_list` - [@hotwatermorning](https://github.com/hotwatermorning).

Excuse me, I had forgot to do rubocop --auto-gen-config.
Now I did the command, added changes of .rubocop_todo.yml into 3701595, and pushed.

@hotwatermorning
Copy link
Contributor Author

hotwatermorning commented Aug 17, 2018

Aren't the modified files for pagination auto-generated? They should not be altered by hand.

I see. The modified files are auto-generated by rake slack:api:update.

(I had altered them by hands. but these changes were overwritten by the command.)

CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
### 0.11.2 (Next)

* Your contribution here.
* [#215](https://github.com/slack-ruby/slack-ruby-client/pull/215): Add more supports for cursor pagination - [@hotwatermorning](https://github.com/hotwatermorning).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this with all the changes in separate items by looking at the diff. For example "Added apps_permissions_users_list" or "files_info, ... now support pagination". Thx.

@dblock
Copy link
Collaborator

dblock commented Aug 17, 2018

This looks good. Update the changelog with all the changes and it's good to go.

@hotwatermorning
Copy link
Contributor Author

Thank you for your kind advice.

I fixed the changelog and pushed. How about this?

@dblock dblock merged commit 98340a9 into slack-ruby:master Aug 18, 2018
@dblock
Copy link
Collaborator

dblock commented Aug 18, 2018

Good, merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants