Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket-level ping monitoring #223

Closed
dblock opened this issue Sep 7, 2018 · 6 comments
Closed

Add websocket-level ping monitoring #223

dblock opened this issue Sep 7, 2018 · 6 comments

Comments

@dblock
Copy link
Collaborator

dblock commented Sep 7, 2018

Ping monitoring in slack-ruby-bot-server checks status of the bot, but faye/websocket-driver-ruby#61 (comment) is saying that we could be sending a ping at websocket level. Which should cause the next read to return a nil and abort an offline situation.

@ioquatix
Copy link
Contributor

@dblock How are you going with this? I am back in NZ and can take a look at it if you still require assistance.

@dblock
Copy link
Collaborator Author

dblock commented Sep 24, 2018

I am not doing any work rn with this. The replacement of celluloid with async has shipped, but did nothing to improve the underlying problem.

@RodneyU215
Copy link
Collaborator

RodneyU215 commented Sep 24, 2018

I started to take a look at this last Friday and I believe I'll have a PR ready for review in a few hours. I'd welcome any feedback and guidance on it!

@RodneyU215
Copy link
Collaborator

RodneyU215 commented Sep 25, 2018

@ioquatix think you'd be interested in reviewing and weighing in on my approach here #226? It's been a while since I've written in Ruby. 😅

@dblock
Copy link
Collaborator Author

dblock commented Oct 17, 2018

Implemented for async-websocket in #226.

@dblock
Copy link
Collaborator Author

dblock commented Oct 31, 2018

Implemented for Celluloid and EM in #236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants