Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from TravisCI to GHA #12

Closed
dblock opened this issue Feb 28, 2022 · 9 comments · Fixed by #13
Closed

Migrate from TravisCI to GHA #12

dblock opened this issue Feb 28, 2022 · 9 comments · Fixed by #13
Labels
chore

Comments

@dblock
Copy link
Contributor

dblock commented Feb 28, 2022

Screen Shot 2022-02-28 at 6 07 38 PM
@dblock dblock added the chore label Feb 28, 2022
@crazyoptimist
Copy link
Collaborator

Let me get this done

@crazyoptimist
Copy link
Collaborator

crazyoptimist commented Mar 1, 2022 •
edited
Loading

Test fails on my local, for the master branch.

Steps to reproduce:

  • Clone the repo
  • Ruby version used: 2.7.2
  • Create a new gemset rvm gemset create slack-ruby
  • Install dependencies bundle install
  • Configure MongoDB connection and set env RACK_ENV=test, DATABASE_ADAPTER=mongoid
  • Run test bundle exec rake spec

Output:

An error occurred while loading ./spec/slack-ruby-bot-server-events/api/endpoints/slack/actions_endpoint_spec.rb.
Failure/Error: require 'slack-ruby-bot-server'

NameError:
  uninitialized constant SlackRubyBotServer::Api::Presenters::TeamPresenter::Boolean
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:13:in `<module:TeamPresenter>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:4:in `<module:Presenters>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:3:in `<module:Api>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:2:in `<module:SlackRubyBotServer>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:1:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `<top (required)>'
# ./lib/slack-ruby-bot-server-events.rb:3:in `require'
# ./lib/slack-ruby-bot-server-events.rb:3:in `<top (required)>'
# ./spec/spec_helper.rb:6:in `<top (required)>'
# ./spec/slack-ruby-bot-server-events/api/endpoints/slack/actions_endpoint_spec.rb:3:in `require'
# ./spec/slack-ruby-bot-server-events/api/endpoints/slack/actions_endpoint_spec.rb:3:in `<top (required)>'

An error occurred while loading ./spec/slack-ruby-bot-server-events/api/endpoints/slack/commands_endpoint_spec.rb.
Failure/Error: require 'slack-ruby-bot-server'

NameError:
  uninitialized constant SlackRubyBotServer::Api::Presenters::TeamPresenter::Boolean
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:13:in `<module:TeamPresenter>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:4:in `<module:Presenters>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:3:in `<module:Api>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:2:in `<module:SlackRubyBotServer>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:1:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `<top (required)>'
# ./lib/slack-ruby-bot-server-events.rb:3:in `require'
# ./lib/slack-ruby-bot-server-events.rb:3:in `<top (required)>'
# ./spec/spec_helper.rb:6:in `<top (required)>'
# ./spec/slack-ruby-bot-server-events/api/endpoints/slack/commands_endpoint_spec.rb:3:in `require'
# ./spec/slack-ruby-bot-server-events/api/endpoints/slack/commands_endpoint_spec.rb:3:in `<top (required)>'

An error occurred while loading ./spec/slack-ruby-bot-server-events/api/endpoints/slack/events_endpoint_spec.rb.
Failure/Error: require 'slack-ruby-bot-server'

NameError:
  uninitialized constant SlackRubyBotServer::Api::Presenters::TeamPresenter::Boolean
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:13:in `<module:TeamPresenter>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:4:in `<module:Presenters>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:3:in `<module:Api>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:2:in `<module:SlackRubyBotServer>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:1:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `<top (required)>'
# ./lib/slack-ruby-bot-server-events.rb:3:in `require'
# ./lib/slack-ruby-bot-server-events.rb:3:in `<top (required)>'
# ./spec/spec_helper.rb:6:in `<top (required)>'
# ./spec/slack-ruby-bot-server-events/api/endpoints/slack/events_endpoint_spec.rb:3:in `require'
# ./spec/slack-ruby-bot-server-events/api/endpoints/slack/events_endpoint_spec.rb:3:in `<top (required)>'

An error occurred while loading ./spec/slack-ruby-bot-server-events/config_spec.rb.
Failure/Error: require 'slack-ruby-bot-server'

NameError:
  uninitialized constant SlackRubyBotServer::Api::Presenters::TeamPresenter::Boolean
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:13:in `<module:TeamPresenter>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:4:in `<module:Presenters>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:3:in `<module:Api>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:2:in `<module:SlackRubyBotServer>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:1:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `<top (required)>'
# ./lib/slack-ruby-bot-server-events.rb:3:in `require'
# ./lib/slack-ruby-bot-server-events.rb:3:in `<top (required)>'
# ./spec/spec_helper.rb:6:in `<top (required)>'
# ./spec/slack-ruby-bot-server-events/config_spec.rb:3:in `require'
# ./spec/slack-ruby-bot-server-events/config_spec.rb:3:in `<top (required)>'

An error occurred while loading ./spec/slack-ruby-bot-server-events/version_spec.rb.
Failure/Error: require 'slack-ruby-bot-server'

NameError:
  uninitialized constant SlackRubyBotServer::Api::Presenters::TeamPresenter::Boolean
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:13:in `<module:TeamPresenter>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:4:in `<module:Presenters>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:3:in `<module:Api>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:2:in `<module:SlackRubyBotServer>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters/team_presenter.rb:1:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api/presenters.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server/api.rb:7:in `<top (required)>'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `require_relative'
# /home/netfan/.rvm/gems/ruby-2.7.2@slack-ruby/gems/slack-ruby-bot-server-1.2.0/lib/slack-ruby-bot-server.rb:13:in `<top (required)>'
# ./lib/slack-ruby-bot-server-events.rb:3:in `require'
# ./lib/slack-ruby-bot-server-events.rb:3:in `<top (required)>'
# ./spec/spec_helper.rb:6:in `<top (required)>'
# ./spec/slack-ruby-bot-server-events/version_spec.rb:3:in `require'
# ./spec/slack-ruby-bot-server-events/version_spec.rb:3:in `<top (required)>'
No examples found.

Finished in 0.00005 seconds (files took 1.34 seconds to load)
0 examples, 0 failures, 5 errors occurred outside of examples

Do you have any clue?
@dblock

@dblock
Copy link
Contributor Author

dblock commented Mar 1, 2022

This happens because Boolean is not a native type in Ruby. It used to be aliased in Grape, see ruby-grape/grape#1551 or ruby-grape/grape#1115. I think changing the code to Grape::API::Boolean or locking grape to an older version should work.

@crazyoptimist
Copy link
Collaborator

The change should happen in slack-ruby-bot-server maybe?
Still not sure where to take an action in this repo..
Sorry but help plz

@dblock
Copy link
Contributor Author

dblock commented Mar 2, 2022

Put up a PR that replaces Travis with GHA and I'll try to fix whatever is broken on top of it?

@crazyoptimist
Copy link
Collaborator

Roger sir

@dblock
Copy link
Contributor Author

dblock commented Mar 7, 2022

I migrated slack-ruby-bot-server to GHA in slack-ruby/slack-ruby-bot-server#142 and slack-ruby/slack-ruby-bot-server#144, so you can copy from there.

The boolean problem was fixed in slack-ruby/slack-ruby-bot-server#140, I released a new version of the gem, so it should go away.

@crazyoptimist
Copy link
Collaborator

Got you, let me try
Thanks

@crazyoptimist
Copy link
Collaborator

Cool
All the tests are green

@crazyoptimist crazyoptimist mentioned this issue Mar 7, 2022
Merged
@dblock dblock closed this as completed in #13 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Travis CI with GHA crazyoptimist/slack-ruby-bot-server-events
2 participants
@dblock @crazyoptimist