[socketmode] Add methods with passing context#923
Merged
Conversation
- added socketmode.Client.RunContext - added socketmode.Client.OpenContext - changed socketmode.Client.openAndDial to pass context - added test coverage for socketmode.Client.openAndDial - added test coverage for socketmode.Client.RunContext - added test coverage for socketmode.Client.OpenContext
Contributor
Author
|
test failed only for go1.12 (go1.13 is minimal according to |
websocket connection freeze on conn.ReadJSON - returned context errors to stop reconnect - closed channel of messages when exit from Client.run - closed websocket connection when context canceled
288d424 to
153f70a
Compare
Member
|
Thanks! (I'm planning to drop support of Go 1.12 in v0.9.0.) |
Contributor
Author
|
Is there any what I can do to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no chance to gracefully shutdown
socketmode.Client. (bug?)Add methods with passing context
Use DialContext instead of Dial
Graceful shutdown websocket.Conn (websocket connection freeze on conn.ReadJSON)
mark test only for go 1.13 and higher
fix typo in json tag
Pull Request Guidelines
These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prepfrom the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines: