chore: unnecessary use of fmt.Sprintf #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Close/re-open for tests. |
ymotongpoo
referenced
this pull request
in ymotongpoo/opentelemetry-collector-extra
Jun 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/slack-go/slack](https://togithub.com/slack-go/slack) | `v0.12.3` -> `v0.13.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>slack-go/slack (github.com/slack-go/slack)</summary> ### [`v0.13.0`](https://togithub.com/slack-go/slack/releases/tag/v0.13.0) [Compare Source](https://togithub.com/slack-go/slack/compare/v0.12.5...v0.13.0) > \[!WARNING]\ > This release includes a breaking change since the last release #### What's Changed ##### Breaking changes - Expose `team_id` parameter for use with org-wide app by [@​candiduslynx](https://togithub.com/candiduslynx) in [https://github.com/slack-go/slack/pull/1283](https://togithub.com/slack-go/slack/pull/1283): Changed interface: | Old | New | | --- | --- | | `Client.GetBotInfo(bot string) (*Bot, error)` | `Client.GetBotInfo(parameters GetBotInfoParameters) (*Bot, error)` | | `Client.GetBotInfoContext(ctx context.Context, bot string)` | `Client.GetBotInfoContext(ctx context.Context, parameters GetBotInfoParameters)` | | `Client.GetTeamProfile() (*TeamProfile, error)` | `GetTeamProfile(teamID ...string) (*TeamProfile, error)` | | `GetTeamProfileContext(ctx context.Context) (*TeamProfile, error)` | `GetTeamProfileContext(ctx context.Context, teamID ...string) (*TeamProfile, error)` | | `Client.GetBillableInfo(user string) (map[string]BillingActive, error)` | `Client.GetBillableInfo(params GetBillableInfoParams) (map[string]BillingActive, error)` | | `Client.GetBillableInfoContext(ctx context.Context, user string) (map[string]BillingActive, error)` | `Client.GetBillableInfoContext(ctx context.Context, params GetBillableInfoParams) (map[string]BillingActive, error)` | | `Client.GetBillableInfoForTeam() (map[string]BillingActive, error)` | dropped, use `Client.GetBillableInfo` with empty params | | `Client.GetBillableInfoForTeamContext(ctx context.Context) (map[string]BillingActive, error)` | dropped, use `Client.GetBillableInfoContext` with empty params | ##### Bug fixes - Block Object: Validate text min and max length by [@​Chagui-](https://togithub.com/Chagui-) in [https://github.com/slack-go/slack/pull/1273](https://togithub.com/slack-go/slack/pull/1273) - fix some typos by [@​yutasb](https://togithub.com/yutasb) in [https://github.com/slack-go/slack/pull/1281](https://togithub.com/slack-go/slack/pull/1281) ##### Enhancements - Add missing message option for link_names by [@​robbydyer](https://togithub.com/robbydyer) in [https://github.com/slack-go/slack/pull/1278](https://togithub.com/slack-go/slack/pull/1278) - Expose `team_id` parameter for use with org-wide app by [@​candiduslynx](https://togithub.com/candiduslynx) in [https://github.com/slack-go/slack/pull/1283](https://togithub.com/slack-go/slack/pull/1283) #### New Contributors - [@​Chagui-](https://togithub.com/Chagui-) made their first contribution in [https://github.com/slack-go/slack/pull/1273](https://togithub.com/slack-go/slack/pull/1273) - [@​robbydyer](https://togithub.com/robbydyer) made their first contribution in [https://github.com/slack-go/slack/pull/1278](https://togithub.com/slack-go/slack/pull/1278) - [@​yutasb](https://togithub.com/yutasb) made their first contribution in [https://github.com/slack-go/slack/pull/1281](https://togithub.com/slack-go/slack/pull/1281) - [@​candiduslynx](https://togithub.com/candiduslynx) made their first contribution in [https://github.com/slack-go/slack/pull/1283](https://togithub.com/slack-go/slack/pull/1283) **Full Changelog**: slack-go/slack@v0.12.5...v0.13.0 ### [`v0.12.5`](https://togithub.com/slack-go/slack/releases/tag/v0.12.5) [Compare Source](https://togithub.com/slack-go/slack/compare/v0.12.4...v0.12.5) #### What's Changed BUGFIX - deal with "true", true, "false", false. - Parse string or boolean for SlashCommand.IsEnterpriseInstall by [@​kpaulisse](https://togithub.com/kpaulisse) in [https://github.com/slack-go/slack/pull/1266](https://togithub.com/slack-go/slack/pull/1266) **Full Changelog**: slack-go/slack@v0.12.4...v0.12.5 ### [`v0.12.4`](https://togithub.com/slack-go/slack/releases/tag/v0.12.4): Non-breaking updates roll-up [Compare Source](https://togithub.com/slack-go/slack/compare/v0.12.3...v0.12.4) #### What's Changed - chore: unnecessary use of fmt.Sprintf by [@​testwill](https://togithub.com/testwill) in [https://github.com/slack-go/slack/pull/1212](https://togithub.com/slack-go/slack/pull/1212) - Add Video Block by [@​walkure](https://togithub.com/walkure) in [https://github.com/slack-go/slack/pull/1210](https://togithub.com/slack-go/slack/pull/1210) - Add connected_team_ids optional field to Conversation by [@​zFlabmonsta](https://togithub.com/zFlabmonsta) in [https://github.com/slack-go/slack/pull/1253](https://togithub.com/slack-go/slack/pull/1253) - Add blocks in slackevents.MessageEvent by [@​invzhi](https://togithub.com/invzhi) in [https://github.com/slack-go/slack/pull/1227](https://togithub.com/slack-go/slack/pull/1227) - Add support for Rich Text Lists by [@​daniel-pieper-personio](https://togithub.com/daniel-pieper-personio) in [https://github.com/slack-go/slack/pull/1155](https://togithub.com/slack-go/slack/pull/1155) - Add support for Rich Text Input by [@​peimanja](https://togithub.com/peimanja) in [https://github.com/slack-go/slack/pull/1240](https://togithub.com/slack-go/slack/pull/1240) - Fix: always add context to errors during block serde by [@​yunginnanet](https://togithub.com/yunginnanet) in [https://github.com/slack-go/slack/pull/1259](https://togithub.com/slack-go/slack/pull/1259) - Edited field in the app mention event by [@​IbirbyZh](https://togithub.com/IbirbyZh) in [https://github.com/slack-go/slack/pull/1256](https://togithub.com/slack-go/slack/pull/1256) - Expose is_enterprise_install field by [@​7ail](https://togithub.com/7ail) in [https://github.com/slack-go/slack/pull/1255](https://togithub.com/slack-go/slack/pull/1255) - feat: Add the ability to set `URL` on `NewButtonBlockElement` via `.WithURL()` by [@​joshbranham](https://togithub.com/joshbranham) in [https://github.com/slack-go/slack/pull/1250](https://togithub.com/slack-go/slack/pull/1250) - Add block element type FileInput by [@​elct9620](https://togithub.com/elct9620) in [https://github.com/slack-go/slack/pull/1249](https://togithub.com/slack-go/slack/pull/1249) - Openid connect by [@​danielmichaels](https://togithub.com/danielmichaels) in [https://github.com/slack-go/slack/pull/1242](https://togithub.com/slack-go/slack/pull/1242) - Add is_enterprise_install flag for org wide installation support by [@​hussachai](https://togithub.com/hussachai) in [https://github.com/slack-go/slack/pull/1225](https://togithub.com/slack-go/slack/pull/1225) - Add an example of updating modal by [@​KouWakai](https://togithub.com/KouWakai) in [https://github.com/slack-go/slack/pull/1142](https://togithub.com/slack-go/slack/pull/1142) - add deleted timestamp for deleted msg events by [@​zFlabmonsta](https://togithub.com/zFlabmonsta) in [https://github.com/slack-go/slack/pull/1261](https://togithub.com/slack-go/slack/pull/1261) - Add slack connect events & tests by [@​Birtato](https://togithub.com/Birtato) in [https://github.com/slack-go/slack/pull/1262](https://togithub.com/slack-go/slack/pull/1262) - Add rich_text_quote and rich_text_preformatted by [@​rusq](https://togithub.com/rusq) in [https://github.com/slack-go/slack/pull/1260](https://togithub.com/slack-go/slack/pull/1260) #### New Contributors - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/slack-go/slack/pull/1212](https://togithub.com/slack-go/slack/pull/1212) - [@​walkure](https://togithub.com/walkure) made their first contribution in [https://github.com/slack-go/slack/pull/1210](https://togithub.com/slack-go/slack/pull/1210) - [@​zFlabmonsta](https://togithub.com/zFlabmonsta) made their first contribution in [https://github.com/slack-go/slack/pull/1253](https://togithub.com/slack-go/slack/pull/1253) - [@​invzhi](https://togithub.com/invzhi) made their first contribution in [https://github.com/slack-go/slack/pull/1227](https://togithub.com/slack-go/slack/pull/1227) - [@​daniel-pieper-personio](https://togithub.com/daniel-pieper-personio) made their first contribution in [https://github.com/slack-go/slack/pull/1155](https://togithub.com/slack-go/slack/pull/1155) - [@​peimanja](https://togithub.com/peimanja) made their first contribution in [https://github.com/slack-go/slack/pull/1240](https://togithub.com/slack-go/slack/pull/1240) - [@​yunginnanet](https://togithub.com/yunginnanet) made their first contribution in [https://github.com/slack-go/slack/pull/1259](https://togithub.com/slack-go/slack/pull/1259) - [@​IbirbyZh](https://togithub.com/IbirbyZh) made their first contribution in [https://github.com/slack-go/slack/pull/1256](https://togithub.com/slack-go/slack/pull/1256) - [@​joshbranham](https://togithub.com/joshbranham) made their first contribution in [https://github.com/slack-go/slack/pull/1250](https://togithub.com/slack-go/slack/pull/1250) - [@​elct9620](https://togithub.com/elct9620) made their first contribution in [https://github.com/slack-go/slack/pull/1249](https://togithub.com/slack-go/slack/pull/1249) - [@​danielmichaels](https://togithub.com/danielmichaels) made their first contribution in [https://github.com/slack-go/slack/pull/1242](https://togithub.com/slack-go/slack/pull/1242) - [@​KouWakai](https://togithub.com/KouWakai) made their first contribution in [https://github.com/slack-go/slack/pull/1142](https://togithub.com/slack-go/slack/pull/1142) - [@​Birtato](https://togithub.com/Birtato) made their first contribution in [https://github.com/slack-go/slack/pull/1262](https://togithub.com/slack-go/slack/pull/1262) **Full Changelog**: slack-go/slack@v0.12.3...v0.12.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines
These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prepfrom the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines: