Migrate JUnit3 based Tests to JUnit 5 (apache#1541)

* chore: migration from junit3 to junit5

Signed-off-by: Sandra Parsick <sandra@parsick.dev>

* chore: remove unused code

Signed-off-by: Sandra Parsick <sandra@parsick.dev>

---------

Signed-off-by: Sandra Parsick <sandra@parsick.dev>

Author: sparsick

src/test/java/org/apache/maven/plugins/dependency/AbstractDependencyMojoTest.java

@@ -26,7 +26,6 @@
 import java.util.Map;
 import java.util.Set;
 
-import junit.framework.TestCase;
 import org.apache.maven.artifact.Artifact;
 import org.apache.maven.model.Dependency;
 import org.apache.maven.model.DependencyManagement;
@@ -36,10 +35,16 @@
 import org.apache.maven.plugins.dependency.testUtils.DependencyArtifactStubFactory;
 import org.apache.maven.plugins.dependency.testUtils.stubs.DependencyProjectStub;
 import org.apache.maven.project.MavenProject;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
-public class TestAnalyzeDepMgt extends TestCase {
+public class TestAnalyzeDepMgt {
 
     AnalyzeDepMgt mojo;
 
@@ -51,8 +56,8 @@ public class TestAnalyzeDepMgt extends TestCase {
 
     DependencyManagement depMgt;
 
-    @Override
-    protected void setUp() throws Exception {
+    @BeforeEach
+    public void setUp() throws Exception {
 
         MavenProject project = new DependencyProjectStub();
         mojo = new AnalyzeDepMgt(project);
@@ -86,6 +91,7 @@ protected void setUp() throws Exception {
         project.setDependencyArtifacts(directArtifacts);
     }
 
+    @Test
     public void testGetManagementKey() throws IOException {
         Dependency dep = new Dependency();
         dep.setArtifactId("artifact");
@@ -145,6 +151,7 @@ public void testGetManagementKey() throws IOException {
         assertEquals(dep.getManagementKey(), mojo.getArtifactManagementKey(artifact));
     }
 
+    @Test
     public void testAddExclusions() {
 
         assertEquals(0, mojo.addExclusions(null).size());
@@ -158,6 +165,7 @@ public void testAddExclusions() {
         assertSame(ex, map.get(mojo.getExclusionKey(ex)));
     }
 
+    @Test
     public void testGetExclusionErrors() {
         List<Exclusion> list = new ArrayList<>();
         list.add(ex);
@@ -172,6 +180,7 @@ public void testGetExclusionErrors() {
         assertEquals(mojo.getExclusionKey(ex), mojo.getExclusionKey(l.get(0)));
     }
 
+    @Test
     public void testGetMismatch() throws IOException {
         Map<String, Dependency> depMgtMap = new HashMap<>();
 
@@ -186,6 +195,7 @@ public void testGetMismatch() throws IOException {
         assertSame(exclusion, results.get(stubFactory.getReleaseArtifact()));
     }
 
+    @Test
     public void testMojo() throws IOException, MojoExecutionException, MojoFailureException {
         mojo.setIgnoreDirect(false);
         // test with nothing in depMgt

src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDepMgt.java

@@ -24,7 +24,6 @@
 import java.util.List;
 import java.util.Random;
 
-import junit.framework.TestCase;
 import org.apache.maven.artifact.Artifact;
 import org.apache.maven.artifact.DefaultArtifact;
 import org.apache.maven.artifact.handler.ArtifactHandler;
@@ -34,19 +33,26 @@
 import org.apache.maven.plugin.logging.Log;
 import org.apache.maven.plugin.testing.SilentLog;
 import org.apache.maven.plugins.dependency.testUtils.stubs.StubSourcesFileMarkerHandler;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 /**
  * @author brianf
  */
-public class TestSourcesMarkerFileHandler extends TestCase {
+public class TestSourcesMarkerFileHandler {
     List<Artifact> artifacts = new ArrayList<>();
 
     Log log = new SilentLog();
 
     File outputFolder;
 
-    protected void setUp() throws Exception {
-        super.setUp();
+    @BeforeEach
+    public void setUp() throws Exception {
 
         ArtifactHandler ah = new DefaultArtifactHandler();
         VersionRange vr = VersionRange.createFromVersion("1.1");
@@ -66,10 +72,12 @@ protected void setUp() throws Exception {
         assertFalse(outputFolder.exists());
     }
 
-    protected void tearDown() {
+    @AfterEach
+    public void tearDown() {
         outputFolder.delete();
     }
 
+    @Test
     public void testSetMarkerResolved() throws MojoExecutionException {
         DefaultFileMarkerHandler handler = new SourcesFileMarkerHandler(artifacts.get(0), this.outputFolder, true);
         assertFalse(handler.isMarkerSet());
@@ -88,6 +96,7 @@ public void testSetMarkerResolved() throws MojoExecutionException {
         assertFalse(outputFolder.exists());
     }
 
+    @Test
     public void testSetMarkerUnresolved() throws MojoExecutionException {
         DefaultFileMarkerHandler handler = new SourcesFileMarkerHandler(artifacts.get(0), this.outputFolder, false);
         assertFalse(handler.isMarkerSet());
@@ -106,6 +115,7 @@ public void testSetMarkerUnresolved() throws MojoExecutionException {
         assertFalse(outputFolder.exists());
     }
 
+    @Test
     public void testBothMarkers() throws MojoExecutionException {
         DefaultFileMarkerHandler handler = new SourcesFileMarkerHandler(artifacts.get(1), this.outputFolder, true);
         DefaultFileMarkerHandler handler2 = new SourcesFileMarkerHandler(artifacts.get(1), this.outputFolder, false);
@@ -121,6 +131,7 @@ public void testBothMarkers() throws MojoExecutionException {
         assertFalse(outputFolder.exists());
     }
 
+    @Test
     public void testMarkerFile() throws MojoExecutionException, IOException {
         DefaultFileMarkerHandler handler = new SourcesFileMarkerHandler(artifacts.get(0), this.outputFolder, true);
         DefaultFileMarkerHandler handler2 = new SourcesFileMarkerHandler(artifacts.get(0), this.outputFolder, false);
@@ -176,10 +187,12 @@ public void testMarkerFile() throws MojoExecutionException, IOException {
         assertFalse(outputFolder.exists());
     }
 
+    @Test
     public void testMarkerTimeStampResolved() throws MojoExecutionException, IOException, InterruptedException {
         doTestMarkerTimeStamp(true);
     }
 
+    @Test
     public void testMarkerTimeStampUnResolved() throws MojoExecutionException, IOException, InterruptedException {
         doTestMarkerTimeStamp(false);
     }
@@ -220,6 +233,7 @@ public void doTestMarkerTimeStamp(boolean resolved)
         assertFalse(resolvedHandler.isMarkerSet());
     }
 
+    @Test
     public void testMarkerFileException() {
         // this stub wraps the file with an object to throw exceptions
         StubSourcesFileMarkerHandler handler =
@@ -231,13 +245,15 @@ public void testMarkerFileException() {
         }
     }
 
+    @Test
     public void testMarkerFileResolvedSetter() {
         SourcesFileMarkerHandler handler = new SourcesFileMarkerHandler(null, null, true);
         assertTrue(handler.isResolved());
         handler.setResolved(false);
         assertFalse(handler.isResolved());
     }
 
+    @Test
     public void testNullParent() throws MojoExecutionException {
         // the parent isn't set so this will create the marker in the local
         // folder. We must clear the
@@ -250,6 +266,7 @@ public void testNullParent() throws MojoExecutionException {
         assertFalse(handler.isMarkerSet());
     }
 
+    @Test
     public void testNullParentResolved() throws MojoExecutionException {
         // the parent isn't set so this will create the marker in the local
         // folder. We must clear the