Refactor & polish code

Author: skywall

app/src/main/java/cz/skywall/multimoduleexample/App.kt

@@ -26,7 +26,7 @@ class App : Application() {
 
         applicationComponent.inject(this)
 
-        // check if everything injected properly
+        // Just a check if everything injected properly. Do not use runBlocking { } on a main thread!
         sharedPreferences.all
         runBlocking {
             val user = apiService.getUser()

app/src/main/java/cz/skywall/multimoduleexample/SplashFragment.kt

@@ -2,8 +2,7 @@ package cz.skywall.multimoduleexample.common
 
 open class SingletonHolder<out T, in A>(private val constructor: (A) -> T) {
 
-    @Volatile
-    private var instance: T? = null
+    @Volatile private var instance: T? = null
 
     fun getInstance(arg: A): T {
         return when {

common/src/main/java/cz/skywall/multimoduleexample/common/SingletonHolder.kt

@@ -1,3 +1,3 @@
 package cz.skywall.multimoduleexample.home.data.repository
 
-class DummyRepository2
+class HomeDummyRepository

home/src/main/java/cz/skywall/multimoduleexample/home/data/repository/DummyRepository2.kt renamed to home/src/main/java/cz/skywall/multimoduleexample/home/data/repository/HomeDummyRepository.kt

@@ -2,7 +2,7 @@ package cz.skywall.multimoduleexample.home.injection
 
 import android.app.Application
 import cz.skywall.multimoduleexample.core.injection.CoreComponent
-import cz.skywall.multimoduleexample.home.data.repository.DummyRepository2
+import cz.skywall.multimoduleexample.home.data.repository.HomeDummyRepository
 import cz.skywall.multimoduleexample.home.ui.home.HomeFragmentComponent
 import cz.skywall.multimoduleexample.home.ui.home.HomeFragmentModule
 import dagger.Component
@@ -30,8 +30,9 @@ interface HomeComponent {
 
 @Module
 class HomeModule {
+
     @Provides
-    fun dummyRepository2(application: Application): DummyRepository2 {
-        return DummyRepository2()
+    fun homeDummyRepository(application: Application): HomeDummyRepository {
+        return HomeDummyRepository()
     }
 }

home/src/main/java/cz/skywall/multimoduleexample/home/injection/HomeInjection.kt

@@ -13,7 +13,7 @@ import cz.skywall.multimoduleexample.common.R as CR
 import cz.skywall.multimoduleexample.R as AR
 import cz.skywall.multimoduleexample.home.base.BaseFragment
 import cz.skywall.multimoduleexample.home.data.repository.DummyRepository
-import cz.skywall.multimoduleexample.home.data.repository.DummyRepository2
+import cz.skywall.multimoduleexample.home.data.repository.HomeDummyRepository
 import cz.skywall.multimoduleexample.network.ApiService
 import kotlinx.android.synthetic.main.fragment_home.*
 import javax.inject.Inject
@@ -24,7 +24,7 @@ class HomeFragment : BaseFragment(), HomeView {
     @Inject lateinit var sharedPreferences: SharedPreferences
     @Inject lateinit var apiService: ApiService
     @Inject lateinit var dummyRepository: DummyRepository
-    @Inject lateinit var dummyRepository2: DummyRepository2
+    @Inject lateinit var homeDummyRepository: HomeDummyRepository
 
     override fun inject() {
         homeComponent.plus(HomeFragmentModule(this)).inject(this)
@@ -42,10 +42,12 @@ class HomeFragment : BaseFragment(), HomeView {
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         requireActivity().startService(Intent(requireActivity(), DummyService::class.java))
 
+        // Check if everything injected properly by accessing instances.
         sharedPreferences.all
         dummyRepository.toString()
-        dummyRepository2.toString()
+        homeDummyRepository.toString()
         homeAdapter.toString()
+        apiService.toString()
 
         combined_text.text =
             """Combined: