[GCP/Provisioner] Assign VMs launched on GCP with service account #2972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2966
Assign the VMs laucnhed on GCP with service account. This is the original behavior which is missed in our new provisioner implementation.
Tested (run the relevant ones):
bash format.sh
sky launch -c test-gcp-sa --cloud gcp --cpus 2 'curl -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/identity?format=standard&audience=gcp"'
; check the VM on the console; `sky launch -c test-gcp-sa-mn --cloud gcp --num-nodes 4 --cpus 2 'curl -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/identity?format=standard&audience=gcp"'
; check the VM on the console`sky launch -c test-gcp-sa-tpu --cloud gcp --gpus tpu-v2-8 'curl -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/identity?format=standard&audience=gcp"'
; check the VM on the console; `sky launch -c test-gcp-sa-tpu --cloud gcp --gpus tpu-v2-8 --num-nodes 2 'curl -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/identity?format=standard&audience=gcp"'
; check the VM on the console; `pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
pytest tests/test_smoke.py::test_gcp_region_and_service_account
bash tests/backward_comaptibility_tests.sh