Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Config improvements #3601

Closed
colinjc opened this issue May 27, 2024 · 3 comments
Closed

[Core] Config improvements #3601

colinjc opened this issue May 27, 2024 · 3 comments
Labels

Comments

@colinjc
Copy link
Contributor

colinjc commented May 27, 2024

Trying to capture some suggestions on how to improve the config file system to better work in large repos and organizations

  1. Instead of the system only being configured in the file located at SKYPILOT_CONFIG, first look for a .skypilot.yaml dotfile in the pwd. The CLI should also accept a --config FILENAME option. They should be parsed and merged in the order of priority (flag, dotfile, user dir file).
  2. All settings in the global config should be overridable in a task.yml
  3. sky check should only look at clouds configured in the global config
  4. Users should be able to specify the cloud target metadata in each task.yml. For example, a user should be able to set GCP project ID per task, instead of having to use the GOOGLE_PROJECT_ID env var
@Michaelvll
Copy link
Collaborator

Thanks for filing the issue @colinjc! Just for a record, we have the restriction for clouds to use (item 3.) merged in #3556, see docs here for allowed_clouds field: https://skypilot.readthedocs.io/en/latest/reference/config.html

We will keep working on the other items.

Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Sep 25, 2024
Copy link

github-actions bot commented Oct 7, 2024

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants