Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Share SSH jump pod across users in the same namespace #2598

Closed
romilbhardwaj opened this issue Sep 23, 2023 · 2 comments · Fixed by #2826
Closed

[k8s] Share SSH jump pod across users in the same namespace #2598

romilbhardwaj opened this issue Sep 23, 2023 · 2 comments · Fixed by #2826
Labels
k8s Kubernetes related items

Comments

@romilbhardwaj
Copy link
Collaborator

We currently create a SSH jump pod per user, even if all of them use the same namespace:

SKY_SSH_JUMP_NAME = f'sky-ssh-jump-{common_utils.get_user_hash()}'

This should instead by based on the kubecontext hash (like we have in get_current_user_identity) so that different users sharing the same namespace should use the same SSH jump pod.

We may also need additionally handle keys and auth from different users on the same ssh jump pod.

@romilbhardwaj romilbhardwaj added the k8s Kubernetes related items label Sep 23, 2023
@kbrgl kbrgl mentioned this issue Dec 12, 2023
5 tasks
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 22, 2024
Copy link

github-actions bot commented Feb 2, 2024

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
@romilbhardwaj romilbhardwaj reopened this Feb 2, 2024
@github-actions github-actions bot removed the Stale label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes related items
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant