Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a third stat #28

Open
chadrien opened this issue Jul 20, 2024 · 3 comments
Open

Add a third stat #28

chadrien opened this issue Jul 20, 2024 · 3 comments

Comments

@chadrien
Copy link

Hey 👋

It would be nice to have the option to add a third (or even more?) stat for which to configure caps. My use case is for blood dk where it would be nice to be able to set these 3 stats:

  • hit
    • at most melee hit cap
  • expertise
    • at least soft cap
  • haste
    • at least 1423
    • at most 1423

(the at least/most combination being used a workaround to set an exact value).

I took a quick look at the code and saw that it's currently pretty hardcoded to only have 2 stats and didn't manage to quickly get a third working, but with some pointers I could also work on PR if it can help :)

@skyler-code
Copy link
Owner

This was one of the first things I looked into when taking over this project and I just don't think I can make it work. The algorithm is just too complex for a single-threaded game like WoW. 2 caps already causes the game to freeze up for my blood dk and just 1 more cap would require optimizations I don't know if I have the time to make and the specs that would even utilize a 3rd cap for this short expansion is maybe 2 or 3.

Also btw, there really isn't an attainable haste cap for any death knight spec. If you're going for haste, get more haste.

@skyler-code
Copy link
Owner

Reopening as this might actually be possible with the recent optimizations

@skyler-code
Copy link
Owner

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants