Create a new abstractions package #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most important changes as of now; 1. BodyBuilder on the MailBase is public get only instead of protected internal. 2. Skyhop.Mail.Abstractions package contains the MailBase class, which is still in the Skyhop.Mail namespace to prevent breaking too much things. 3. Two packages are now generated instead of one.
synercoder
reviewed
Feb 16, 2021
synercoder
approved these changes
Feb 17, 2021
#notTested
Collaborator
|
I added 2 conditional references in the base csproj |
Member
Author
|
Thanks, overlooked that part! Ps. while I'm at it, let me check whether I can configure actions to automatically push to NuGet. |
synercoder
reviewed
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most important changes as of now;