SK-2142 return None on empty error response #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raushan-skyflow
force-pushed
the
raushan/SK-2142-return-none-on-empty-error-response
branch
from
3f33fb4 to
9ba4d96
Compare
raushan-skyflow
requested review from
skyflow-shravan,
skyflow-vivek and
saileshwar-skyflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the error response to align with the recent changes introduced in Node SDK v2 & other server side SDK, where the errors key is set to null when no errors are present, instead of returning an empty array.
Why:
Outcome:
Nonein case of empty array response.Test: