aadarsh-st/SK-2521: Fix review comment

Author: aadarsh-st

skyflow/service_account/_utils.py

@@ -38,7 +38,7 @@ def generate_bearer_token(credentials_file_path, options = None, logger = None):
             except Exception:
                 log_error_log(SkyflowMessages.ErrorLogs.INVALID_CREDENTIALS_FILE.value, logger = logger)
                 raise SkyflowError(SkyflowMessages.Error.FILE_INVALID_JSON.value.format(credentials_file_path), invalid_input_error_code)
-    except FileNotFoundError:
+    except OSError:
         raise SkyflowError(SkyflowMessages.Error.INVALID_CREDENTIAL_FILE_PATH.value, invalid_input_error_code)
 
     result = get_service_account_token(credentials, options, logger)

skyflow/vault/controller/_connections.py

@@ -29,17 +29,17 @@ def invoke(self, request: InvokeConnectionRequest):
 
         log_info(SkyflowMessages.Info.INVOKE_CONNECTION_TRIGGERED.value, self.__vault_client.get_logger())
 
+        response = None
         try:
             response = session.send(invoke_connection_request)
-            try:
-                invoke_connection_response = parse_invoke_connection_response(response)
-                return invoke_connection_response
-            finally:
-                response.close()
+            return parse_invoke_connection_response(response)
+
         except Exception as e:
             log_error_log(SkyflowMessages.ErrorLogs.INVOKE_CONNECTION_REQUEST_REJECTED.value, self.__vault_client.get_logger())
             if isinstance(e, SkyflowError): raise e
             raise SkyflowError(SkyflowMessages.Error.INVOKE_CONNECTION_FAILED.value,
                                SkyflowMessages.ErrorCodes.SERVER_ERROR.value)
         finally:
-            session.close()
+            if response is not None:
+                response.close()
+            session.close()

skyflow/vault/controller/_detect.py

@@ -79,9 +79,7 @@ def __poll_for_processed_file(self, run_id, max_wait_time=64):
                                 current_wait_time = next_wait_time
                             time.sleep(wait_time)
                     elif status == 'SUCCESS' or status == 'FAILED':
-                        # Retrieve the response data before closing the HTTP response
-                        result = response
-                        return result
+                        return response
                 finally:
                     http_response.close()
         except Exception as e:
@@ -289,9 +287,7 @@ def deidentify_file(self, request: DeidentifyFileRequest):
         file_extension = self._get_file_extension(file_name) if file_name else None
 
         # Track if we need to close the file (only if it was opened from file_path)
-        file_needs_closing = False
-        if hasattr(request.file, 'file_path') and request.file.file_path is not None:
-            file_needs_closing = True
+        file_needs_closing = hasattr(request.file, 'file_path') and request.file.file_path is not None
 
         try:
             file_content = file_obj.read()